Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: sky/engine/bindings/scripts/templates/interface_dart.template

Issue 943153002: Make it possible for sky-element to register any tag name (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/custom/dart_element_custom.cc ('k') | sky/engine/core/dom/Element.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/scripts/templates/interface_dart.template
diff --git a/sky/engine/bindings/scripts/templates/interface_dart.template b/sky/engine/bindings/scripts/templates/interface_dart.template
index 3ec63ac3c89cff72fdd05738edf56110b99dbcb4..d99e7a614bc0ce5710016e33e1cb1cd943373711 100644
--- a/sky/engine/bindings/scripts/templates/interface_dart.template
+++ b/sky/engine/bindings/scripts/templates/interface_dart.template
@@ -19,11 +19,11 @@ part of sky.core;
{%- endfor -%}
{%- endmacro -%}
-{% if not constructors %}abstract {% endif -%}
+{% if not constructors and not custom_constructors %}abstract {% endif -%}
class {{interface_name}} extends {{ parent_interface if parent_interface else 'NativeFieldWrapperClass2' }} {
// Constructors
{# TODO(eseidel): We only ever have one constructor. #}
-{%- for constructor in constructors %}
+{%- for constructor in constructors + custom_constructors %}
void _constructor(
{%- for arg in constructor.arguments -%}
{{ arg.dart_type }} {{ arg.name }}{% if not loop.last %}, {% endif %}
« no previous file with comments | « sky/engine/bindings/custom/dart_element_custom.cc ('k') | sky/engine/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698