Issue 943113003: Add render tree dump and pixel tests for statically placed position:absolute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943113003: Add render tree dump and pixel tests for statically placed position:absolute. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add render tree dump and pixel tests for statically placed position:absolute. This exposes a bug that we position and size position:absolute correctly inside paragraphs, but we fail to paint them. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/06ea81fb47fb0e133a03ad046aa7aa87eb74fba3

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -1 line)			Patch
A	sky/tests/layout/position-absolute.sky	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	sky/tests/layout/position-absolute-expected.txt	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	sky/tests/layout/position-absolute-pixels.sky	View	1 chunk	+62 lines, -0 lines	0 comments	Download
A +	sky/tests/layout/position-absolute-pixels-expected.sky	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 10 months ago (2015-02-21 02:20:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
06ea81fb47fb0e133a03ad046aa7aa87eb74fba3 (presubmit successful).