Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
943113002:
Add new site isolation trybot. (Closed)
|
Created:
5 years, 10 months ago by alexmos Modified:
5 years, 9 months ago CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, Charlie Reis Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master Target Ref:
refs/heads/master Project:
tools Visibility:
Public. |
DescriptionAdd new site isolation trybot.
The trybot is based on the recipe used by Linux Site Isolation FYI bot (see chromium.fyi.json).
BUG=454899
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294282
Patch Set 1 #
Total comments: 5
Patch Set 2 : Address hinoka's comments #Patch Set 3 : Add generated files, make the build directory shared #Patch Set 4 : Rebase #
Messages
Total messages: 31 (13 generated)
alexmos@chromium.org changed reviewers: + hinoka@chromium.org
alexmos@chromium.org changed reviewers: + friedman@chromium.org
lgtm % comments https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... File masters/master.tryserver.chromium.linux/master.cfg (right): https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... masters/master.tryserver.chromium.linux/master.cfg:269: # Share build directory with compatible existing builders to save space. Remove this comment, its not actually true in this case :P https://codereview.chromium.org/943113002/diff/1/scripts/slave/recipes/chromi... File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/943113002/diff/1/scripts/slave/recipes/chromi... scripts/slave/recipes/chromium_trybot.py:240: 'tester': 'Site Isolation Linux', I don't think you need this. I think this is just for builder/tester split configs (ie, if the compiler and tester are on different builders).
New patchsets have been uploaded after l-g-t-m from hinoka@chromium.org
Thanks, two questions (one below). There were two files generated along with the recipe update: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation.json scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation_analyze.json Are those needed as well? When I was updating our FYI bot config, I was told these are obsolete, but all other builders seem to have these files, so just wanted to make sure. https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... File masters/master.tryserver.chromium.linux/master.cfg (right): https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... masters/master.tryserver.chromium.linux/master.cfg:269: # Share build directory with compatible existing builders to save space. On 2015/02/21 01:29:11, hinoka wrote: > Remove this comment, its not actually true in this case :P Comment removed. Thinking about this though, our bot doesn't need any special build flags; the only difference from regular trybots is passing a runtime flag --site-per-process to the test binaries. So, do we actually want to use a new build dir for our bot? https://codereview.chromium.org/943113002/diff/1/scripts/slave/recipes/chromi... File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/943113002/diff/1/scripts/slave/recipes/chromi... scripts/slave/recipes/chromium_trybot.py:240: 'tester': 'Site Isolation Linux', On 2015/02/21 01:29:11, hinoka wrote: > I don't think you need this. I think this is just for builder/tester split > configs (ie, if the compiler and tester are on different builders). Done.
Ping. Want to settle two questions below before CQing this. On 2015/02/21 01:52:57, alexmos wrote: > Thanks, two questions (one below). There were two files generated along with > the recipe update: > scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation.json > scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation_analyze.json > > Are those needed as well? When I was updating our FYI bot config, I was told > these are obsolete, but all other builders seem to have these files, so just > wanted to make sure. > > https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... > File masters/master.tryserver.chromium.linux/master.cfg (right): > > https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... > masters/master.tryserver.chromium.linux/master.cfg:269: # Share build directory > with compatible existing builders to save space. > On 2015/02/21 01:29:11, hinoka wrote: > > Remove this comment, its not actually true in this case :P > > Comment removed. Thinking about this though, our bot doesn't need any special > build flags; the only difference from regular trybots is passing a runtime flag > --site-per-process to the test binaries. So, do we actually want to use a new > build dir for our bot? > > https://codereview.chromium.org/943113002/diff/1/scripts/slave/recipes/chromi... > File scripts/slave/recipes/chromium_trybot.py (right): > > https://codereview.chromium.org/943113002/diff/1/scripts/slave/recipes/chromi... > scripts/slave/recipes/chromium_trybot.py:240: 'tester': 'Site Isolation Linux', > On 2015/02/21 01:29:11, hinoka wrote: > > I don't think you need this. I think this is just for builder/tester split > > configs (ie, if the compiler and tester are on different builders). > > Done.
full_tryserver_chromium_linux_linux_site_isolation.json is needed, i'm not sure why the analyze popped out (I think thats for coverage). Either way the CQ will reject the patch if you're missing any files, so feel free to use that as a safety net. https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... File masters/master.tryserver.chromium.linux/master.cfg (right): https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... masters/master.tryserver.chromium.linux/master.cfg:269: # Share build directory with compatible existing builders to save space. On 2015/02/21 01:52:57, alexmos wrote: > On 2015/02/21 01:29:11, hinoka wrote: > > Remove this comment, its not actually true in this case :P > > Comment removed. Thinking about this though, our bot doesn't need any special > build flags; the only difference from regular trybots is passing a runtime flag > --site-per-process to the test binaries. So, do we actually want to use a new > build dir for our bot? Hm you're right. Maybe its okay to share with the linux (or other) folder if you can confirm they have the same build flags. You should be able to glean that from the expectations.
Thanks! On 2015/02/24 19:49:31, hinoka wrote: > full_tryserver_chromium_linux_linux_site_isolation.json is needed, i'm not sure > why the analyze popped out (I think thats for coverage). > > Either way the CQ will reject the patch if you're missing any files, so feel > free to use that as a safety net. OK, I added both files. > https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... > File masters/master.tryserver.chromium.linux/master.cfg (right): > > https://codereview.chromium.org/943113002/diff/1/masters/master.tryserver.chr... > masters/master.tryserver.chromium.linux/master.cfg:269: # Share build directory > with compatible existing builders to save space. > On 2015/02/21 01:52:57, alexmos wrote: > > On 2015/02/21 01:29:11, hinoka wrote: > > > Remove this comment, its not actually true in this case :P > > > > Comment removed. Thinking about this though, our bot doesn't need any special > > build flags; the only difference from regular trybots is passing a runtime > flag > > --site-per-process to the test binaries. So, do we actually want to use a new > > build dir for our bot? > > Hm you're right. Maybe its okay to share with the linux (or other) folder if > you can confirm they have the same build flags. You should be able to glean > that from the expectations. I changed the build directory to be 'linux'; our build flags look the same as the regular Linux trybots.
The CQ bit was checked by alexmos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org Link to the patchset: https://codereview.chromium.org/943113002/#ps40001 (title: "Add generated files, make the build directory shared")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943113002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 943113002-40001 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
tests/masters_recipes_test.py (24.54s) failed
Traceback (most recent call last):
File "tests/masters_recipes_test.py", line 231, in <module>
sys.exit(main(sys.argv[1:]))
File "tests/masters_recipes_test.py", line 195, in main
main_waterfall_master = 'master.' + bot_config['mastername']
File
"/b/infra_internal/commit_queue/workdir/tools/build/third_party/infra/libs/infra_types/infra_types.py",
line 77, in __getitem__
return self._d[key]
KeyError: 'mastername'
scripts/slave/unittests/recipe_simulation_test.py (23.19s) failed
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Process
Process-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 117, in gen_loop_process
result_queue.put_nowait)
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/type_definitions.py",
line 351, in gen_stage_loop
for test in tests:
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 70, in generate_tests
root_test = next(gen_inst)
File "scripts/slave/unittests/recipe_simulation_test.py", line 53, in
GenerateTests
for test_data in recipe.GenTests(test_api):
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.py",
line 460, in GenTests
(api.empty_test_data() if analyze else suppress_analyze()) +
File
"/b/infra_internal/commit_queue/workdir/tools/build/third_party/infra/libs/infra_types/infra_types.py",
line 77, in __getitem__
return self._d[key]
KeyError: 'mastername'
................................
----------------------------------------------------------------------
Ran 515 tests in 18.153s
OK
Coverage Report Stmts Miss Cover
Missing
---------------------------------------------------------------------------------------
scripts/slave/recipe_modules/adb/api 27 6 78%
15-18, 21, 25
scripts/slave/recipe_modules/amp/api 100 81 19%
11-13, 17-19, 23, 27-29, 33, 37, 41, 47-77, 84-123, 129-152, 167-170, 184-187,
215-252
scripts/slave/recipe_modules/amp/example 18 13 28%
104-149, 152-169
scripts/slave/recipe_modules/android/api 87 72 17%
11-12, 16, 22-31, 34-38, 41-47, 60-71, 75-87, 92-129, 132-134, 140-142, 148-167,
180-183
scripts/slave/recipe_modules/android/example 16 13 19%
11-27, 34
scripts/slave/recipe_modules/android/test_api 4 1 75%
5
scripts/slave/recipe_modules/archive/api 68 1 99%
34
scripts/slave/recipe_modules/bot_update/api 109 4 96%
154, 200-201, 211
scripts/slave/recipe_modules/bot_update/example 22 19 14%
13-23, 29-82
scripts/slave/recipe_modules/bot_update/test_api 23 3 87%
40, 52-53
scripts/slave/recipe_modules/buildbot/api 7 3 57%
11, 21-24
scripts/slave/recipe_modules/chromite/api 35 25 29%
13-17, 21-35, 42-55, 59, 65
scripts/slave/recipe_modules/chromite/example 12 9 25%
11-19, 24-25
scripts/slave/recipe_modules/chromium/api 314 58 82%
15-16, 19-22, 25, 66, 94-99, 102-109, 208-210, 240, 278, 283, 289, 324, 330,
336, 338, 373-396, 413, 419, 425-446, 457-462, 470, 603-604, 684-685
scripts/slave/recipe_modules/chromium_android/api 266 76 71%
77-79, 83, 87, 104-115, 142, 188, 190, 204, 211, 218, 231, 240-251, 259-268,
278, 300-301, 309, 343-356, 364, 366, 404-410, 425, 466, 486-487, 496, 500-503,
514, 526, 528, 530, 536, 539, 541, 601, 644-654, 671, 673, 688-694, 702-706,
714-731
scripts/slave/recipe_modules/chromium_android/example 57 52 9%
73-158, 161-186
scripts/slave/recipe_modules/chromium_tests/api 249 17 93%
264-267, 395-402, 580, 588-590, 612, 619
scripts/slave/recipe_modules/chromium_tests/example 14 11 21%
16-35, 40-71
scripts/slave/recipe_modules/commit_position/api 44 8 82%
24-25, 34-35, 44-45, 67-68
scripts/slave/recipe_modules/commit_position/example 31 24 23%
19-49, 53-75
scripts/slave/recipe_modules/cronet/example 18 13 28%
27-37, 40-48
scripts/slave/recipe_modules/disk/api 28 25 11%
33-74
scripts/slave/recipe_modules/disk/example 20 16 20%
16-37, 43-59
scripts/slave/recipe_modules/disk/test_api 5 2 60%
10-11
scripts/slave/recipe_modules/file/api 21 7 67%
16, 30, 44-47, 52
scripts/slave/recipe_modules/file/example 26 21 19%
26-57, 61
scripts/slave/recipe_modules/filter/api 81 15 81%
108, 117, 150-156, 159-160, 163-164, 167-169, 171
scripts/slave/recipe_modules/filter/example 24 21 13%
16-33, 37-148
scripts/slave/recipe_modules/gclient/api 130 15 88%
67, 93, 97, 115, 155-160, 226-234, 273
scripts/slave/recipe_modules/gclient/example 22 19 14%
11-36, 39
scripts/slave/recipe_modules/gclient/test_api 11 1 91%
34
scripts/slave/recipe_modules/generator_script/api 41 38 7%
27-81
scripts/slave/recipe_modules/generator_script/example 11 8 27%
15-18, 21-55
scripts/slave/recipe_modules/generator_script/test_api 5 2 60%
5-6
scripts/slave/recipe_modules/git/api 131 78 40%
20, 25-29, 33-35, 40-42, 57-107, 141-148, 156, 161, 184-186, 191-198, 202,
207-208, 212, 224, 232, 244-252, 274-277, 290-297
scripts/slave/recipe_modules/git/example 35 32 9%
16-63, 67-123
scripts/slave/recipe_modules/git/test_api 4 1 75%
9
scripts/slave/recipe_modules/gitiles/api 23 16 30%
13-19, 23-30, 44-60, 72-76
scripts/slave/recipe_modules/gitiles/example 8 5 38%
12-15, 19
scripts/slave/recipe_modules/gitiles/test_api 8 3 63%
9, 12, 15
scripts/slave/recipe_modules/goma/example 5 2 60%
10, 14
scripts/slave/recipe_modules/gpu/api 170 88 48%
34-101, 118-127, 135-144, 164, 167-168, 172-232, 238-241, 266, 289-290, 300-305,
315-316, 371, 426, 433-436, 447, 517-520, 522
scripts/slave/recipe_modules/gpu/test_api 11 3 73%
22, 30, 38
scripts/slave/recipe_modules/gsutil/api 95 38 60%
68-72, 90-100, 106-110, 113-117, 133-140, 148-151, 170-187
scripts/slave/recipe_modules/gsutil/example 18 15 17%
13-46, 53
scripts/slave/recipe_modules/ios/api 92 79 14%
10-11, 15-31, 35-37, 41-42, 46-47, 51-55, 64-113, 127-174, 182-256, 263-273,
282-305
scripts/slave/recipe_modules/ios/test_api 17 6 65%
12, 15, 20, 23, 26, 38
scripts/slave/recipe_modules/isolate/api 79 18 77%
24, 42, 89-99, 105, 172-178, 247, 271-273, 277-282
scripts/slave/recipe_modules/isolate/example 25 22 12%
17-41, 45-70
scripts/slave/recipe_modules/json/api 54 3 94%
37, 78-79
scripts/slave/recipe_modules/json/example 8 5 38%
12-17, 21
scripts/slave/recipe_modules/json/test_api 12 4 67%
12-15
scripts/slave/recipe_modules/libyuv/api 4 1 75%
9
scripts/slave/recipe_modules/omahaproxy/api 19 13 32%
16-18, 21-36
scripts/slave/recipe_modules/path/api 120 8 93%
48, 179, 257-258, 280-284
scripts/slave/recipe_modules/path/example 16 13 19%
13-34, 39-42
scripts/slave/recipe_modules/path/test_api 13 6 54%
8-9, 12, 15-17
scripts/slave/recipe_modules/perf_dashboard/api 20 11 45%
15-18, 43-52, 60, 64
scripts/slave/recipe_modules/perf_dashboard/example 16 13 19%
20-36, 39-41
scripts/slave/recipe_modules/pgo/api 38 30 21%
36, 43-48, 55-69, 76-89, 97-121
scripts/slave/recipe_modules/properties/api 15 1 93%
37
scripts/slave/recipe_modules/properties/example 9 5 44%
10-11, 14-18
scripts/slave/recipe_modules/properties/test_api 22 3 86%
44-51
scripts/slave/recipe_modules/raw_io/api 77 4 95%
59-60, 98-99
scripts/slave/recipe_modules/raw_io/example 18 15 17%
14-56, 61
scripts/slave/recipe_modules/repo/api 28 17 39%
18-19, 23-25, 29, 33-34, 41-46, 52-53, 60
scripts/slave/recipe_modules/repo/example 10 7 30%
11-16, 20
scripts/slave/r…
(message too large)
hinoka@: the presubmit check on the CQ is failing, though the same recipe tests were passing for me locally. It looks like the recipe tests have trouble looking up 'mastername'. Do some of these changes need to land before others? (In particular, does chromium_trybot.* needs to land before the master/slave.cfg changes?)
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943113002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 943113002-40001 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
tests/masters_recipes_test.py (22.83s) failed
The following builders from chromium recipe
do not exist in master config for master.chromium.mac:
iOS Device
iOS Device (ninja)
iOS Simulator (dbg)
Traceback (most recent call last):
File "tests/masters_recipes_test.py", line 231, in <module>
sys.exit(main(sys.argv[1:]))
File "tests/masters_recipes_test.py", line 195, in main
main_waterfall_master = 'master.' + bot_config['mastername']
File
"/b/infra_internal/commit_queue/workdir/tools/build/third_party/infra/libs/infra_types/infra_types.py",
line 77, in __getitem__
return self._d[key]
KeyError: 'mastername'
scripts/slave/unittests/recipe_simulation_test.py (22.41s) failed
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Process
Process-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 117, in gen_loop_process
result_queue.put_nowait)
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/type_definitions.py",
line 351, in gen_stage_loop
for test in tests:
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 70, in generate_tests
root_test = next(gen_inst)
File "scripts/slave/unittests/recipe_simulation_test.py", line 53, in
GenerateTests
for test_data in recipe.GenTests(test_api):
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.py",
line 460, in GenTests
(api.empty_test_data() if analyze else suppress_analyze()) +
File
"/b/infra_internal/commit_queue/workdir/tools/build/third_party/infra/libs/infra_types/infra_types.py",
line 77, in __getitem__
return self._d[key]
KeyError: 'mastername'
................................
----------------------------------------------------------------------
Ran 514 tests in 19.176s
OK
Coverage Report Stmts Miss Cover
Missing
---------------------------------------------------------------------------------------
scripts/slave/recipe_modules/adb/api 27 6 78%
15-18, 21, 25
scripts/slave/recipe_modules/amp/api 100 81 19%
11-13, 17-19, 23, 27-29, 33, 37, 41, 47-77, 84-123, 129-152, 167-170, 184-187,
215-252
scripts/slave/recipe_modules/amp/example 18 13 28%
104-149, 152-169
scripts/slave/recipe_modules/android/api 87 72 17%
11-12, 16, 22-31, 34-38, 41-47, 60-71, 75-87, 92-129, 132-134, 140-142, 148-167,
180-183
scripts/slave/recipe_modules/android/example 16 13 19%
11-27, 34
scripts/slave/recipe_modules/android/test_api 4 1 75%
5
scripts/slave/recipe_modules/archive/api 68 1 99%
34
scripts/slave/recipe_modules/bot_update/api 109 4 96%
154, 200-201, 211
scripts/slave/recipe_modules/bot_update/example 22 19 14%
13-23, 29-82
scripts/slave/recipe_modules/bot_update/test_api 23 3 87%
40, 52-53
scripts/slave/recipe_modules/buildbot/api 7 3 57%
11, 21-24
scripts/slave/recipe_modules/chromite/api 35 25 29%
13-17, 21-35, 42-55, 59, 65
scripts/slave/recipe_modules/chromite/example 12 9 25%
11-19, 24-25
scripts/slave/recipe_modules/chromium/api 314 58 82%
15-16, 19-22, 25, 66, 94-99, 102-109, 208-210, 240, 278, 283, 289, 324, 330,
336, 338, 373-396, 413, 419, 425-446, 457-462, 470, 603-604, 684-685
scripts/slave/recipe_modules/chromium_android/api 266 76 71%
77-79, 83, 87, 104-115, 142, 188, 190, 204, 211, 218, 231, 240-251, 259-268,
278, 300-301, 309, 343-356, 364, 366, 404-410, 425, 466, 486-487, 496, 500-503,
514, 526, 528, 530, 536, 539, 541, 601, 644-654, 671, 673, 688-694, 702-706,
714-731
scripts/slave/recipe_modules/chromium_android/example 57 52 9%
73-158, 161-186
scripts/slave/recipe_modules/chromium_tests/api 249 17 93%
264-267, 395-402, 580, 588-590, 612, 619
scripts/slave/recipe_modules/chromium_tests/example 14 11 21%
16-35, 40-71
scripts/slave/recipe_modules/commit_position/api 44 8 82%
24-25, 34-35, 44-45, 67-68
scripts/slave/recipe_modules/commit_position/example 31 24 23%
19-49, 53-75
scripts/slave/recipe_modules/cronet/example 18 13 28%
27-37, 40-48
scripts/slave/recipe_modules/disk/api 28 25 11%
33-74
scripts/slave/recipe_modules/disk/example 20 16 20%
16-37, 43-59
scripts/slave/recipe_modules/disk/test_api 5 2 60%
10-11
scripts/slave/recipe_modules/file/api 21 7 67%
16, 30, 44-47, 52
scripts/slave/recipe_modules/file/example 26 21 19%
26-57, 61
scripts/slave/recipe_modules/filter/api 86 18 79%
109, 118, 122, 155-165, 168-169, 172-173, 176-178, 180
scripts/slave/recipe_modules/filter/example 25 22 12%
17-34, 38-159
scripts/slave/recipe_modules/gclient/api 130 15 88%
67, 93, 97, 115, 155-160, 226-234, 273
scripts/slave/recipe_modules/gclient/example 22 19 14%
11-36, 39
scripts/slave/recipe_modules/gclient/test_api 11 1 91%
34
scripts/slave/recipe_modules/generator_script/api 41 38 7%
27-81
scripts/slave/recipe_modules/generator_script/example 11 8 27%
15-18, 21-55
scripts/slave/recipe_modules/generator_script/test_api 5 2 60%
5-6
scripts/slave/recipe_modules/git/api 131 78 40%
20, 25-29, 33-35, 40-42, 57-107, 141-148, 156, 161, 184-186, 191-198, 202,
207-208, 212, 224, 232, 244-252, 274-277, 290-297
scripts/slave/recipe_modules/git/example 35 32 9%
16-63, 67-123
scripts/slave/recipe_modules/git/test_api 4 1 75%
9
scripts/slave/recipe_modules/gitiles/api 23 16 30%
13-19, 23-30, 44-60, 72-76
scripts/slave/recipe_modules/gitiles/example 8 5 38%
12-15, 19
scripts/slave/recipe_modules/gitiles/test_api 8 3 63%
9, 12, 15
scripts/slave/recipe_modules/goma/example 5 2 60%
10, 14
scripts/slave/recipe_modules/gpu/api 170 88 48%
34-101, 118-127, 135-144, 164, 167-168, 172-232, 238-241, 266, 289-290, 300-305,
315-316, 371, 426, 433-436, 447, 517-520, 522
scripts/slave/recipe_modules/gpu/test_api 11 3 73%
22, 30, 38
scripts/slave/recipe_modules/gsutil/api 95 38 60%
68-72, 90-100, 106-110, 113-117, 133-140, 148-151, 170-187
scripts/slave/recipe_modules/gsutil/example 18 15 17%
13-46, 53
scripts/slave/recipe_modules/ios/api 92 79 14%
10-11, 15-31, 35-37, 41-42, 46-47, 51-55, 64-113, 127-174, 182-256, 263-273,
282-305
scripts/slave/recipe_modules/ios/test_api 17 6 65%
12, 15, 20, 23, 26, 38
scripts/slave/recipe_modules/isolate/api 79 18 77%
24, 42, 89-99, 105, 172-178, 247, 271-273, 277-282
scripts/slave/recipe_modules/isolate/example 25 22 12%
17-41, 45-70
scripts/slave/recipe_modules/json/api 54 3 94%
37, 78-79
scripts/slave/recipe_modules/json/example 8 5 38%
12-17, 21
scripts/slave/recipe_modules/json/test_api 12 4 67%
12-15
scripts/slave/recipe_modules/libyuv/api 4 1 75%
9
scripts/slave/recipe_modules/omahaproxy/api 19 13 32%
16-18, 21-36
scripts/slave/recipe_modules/path/api 120 8 93%
48, 179, 257-258, 280-284
scripts/slave/recipe_modules/path/example 16 13 19%
13-34, 39-42
scripts/slave/recipe_modules/path/test_api 13 6 54%
8-9, 12, 15-17
scripts/slave/recipe_modules/perf_dashboard/api 20 11 45%
15-18, 43-52, 60, 64
scripts/slave/recipe_modules/perf_dashboard/example 16 13 19%
20-36, 39-41
scripts/slave/recipe_modules/pgo/api 38 30 21%
36, 43-48, 55-69, 76-89, 97-121
scripts/slave/recipe_modules/properties/api 15 1 93%
37
scripts/slave/recipe_modules/properties/example 9 5 44%
10-11, 14-18
scripts/slave/recipe_modules/properties/test_api 22 3 86%
44-51
scripts/slave/recipe_modules/raw_io/api 77 4 95%
59-60, 98-99
scripts/slave/recipe_modules/raw_io/example 18 15 17%
14-56, 61
scripts/slave/recipe_modules/repo/api 28 17 …
(message too large)
The CQ bit was checked by alexmos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943113002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 943113002-40001 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
tests/masters_recipes_test.py (22.44s) failed
Traceback (most recent call last):
File "tests/masters_recipes_test.py", line 231, in <module>
sys.exit(main(sys.argv[1:]))
File "tests/masters_recipes_test.py", line 195, in main
main_waterfall_master = 'master.' + bot_config['mastername']
File
"/b/infra_internal/commit_queue/workdir/tools/build/third_party/infra/libs/infra_types/infra_types.py",
line 77, in __getitem__
return self._d[key]
KeyError: 'mastername'
scripts/slave/unittests/recipe_simulation_test.py (22.36s) failed
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Process
Process-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 117, in gen_loop_process
result_queue.put_nowait)
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/type_definitions.py",
line 351, in gen_stage_loop
for test in tests:
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/unittests/expect_tests/pipeline.py",
line 70, in generate_tests
root_test = next(gen_inst)
File "scripts/slave/unittests/recipe_simulation_test.py", line 53, in
GenerateTests
for test_data in recipe.GenTests(test_api):
File
"/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.py",
line 460, in GenTests
(api.empty_test_data() if analyze else suppress_analyze()) +
File
"/b/infra_internal/commit_queue/workdir/tools/build/third_party/infra/libs/infra_types/infra_types.py",
line 77, in __getitem__
return self._d[key]
KeyError: 'mastername'
................................
----------------------------------------------------------------------
Ran 514 tests in 18.018s
OK
Coverage Report Stmts Miss Cover
Missing
---------------------------------------------------------------------------------------
scripts/slave/recipe_modules/adb/api 27 6 78%
15-18, 21, 25
scripts/slave/recipe_modules/amp/api 100 81 19%
11-13, 17-19, 23, 27-29, 33, 37, 41, 47-77, 84-123, 129-152, 167-170, 184-187,
215-252
scripts/slave/recipe_modules/amp/example 18 13 28%
104-149, 152-169
scripts/slave/recipe_modules/android/api 87 72 17%
11-12, 16, 22-31, 34-38, 41-47, 60-71, 75-87, 92-129, 132-134, 140-142, 148-167,
180-183
scripts/slave/recipe_modules/android/example 16 13 19%
11-27, 34
scripts/slave/recipe_modules/android/test_api 4 1 75%
5
scripts/slave/recipe_modules/archive/api 68 1 99%
34
scripts/slave/recipe_modules/bot_update/api 109 4 96%
154, 200-201, 211
scripts/slave/recipe_modules/bot_update/example 22 19 14%
13-23, 29-82
scripts/slave/recipe_modules/bot_update/test_api 23 3 87%
40, 52-53
scripts/slave/recipe_modules/buildbot/api 7 3 57%
11, 21-24
scripts/slave/recipe_modules/chromite/api 35 25 29%
13-17, 21-35, 42-55, 59, 65
scripts/slave/recipe_modules/chromite/example 12 9 25%
11-19, 24-25
scripts/slave/recipe_modules/chromium/api 314 58 82%
15-16, 19-22, 25, 66, 94-99, 102-109, 208-210, 240, 278, 283, 289, 324, 330,
336, 338, 373-396, 413, 419, 425-446, 457-462, 470, 603-604, 684-685
scripts/slave/recipe_modules/chromium_android/api 266 76 71%
77-79, 83, 87, 104-115, 142, 188, 190, 204, 211, 218, 231, 240-251, 259-268,
278, 300-301, 309, 343-356, 364, 366, 404-410, 425, 466, 486-487, 496, 500-503,
514, 526, 528, 530, 536, 539, 541, 601, 644-654, 671, 673, 688-694, 702-706,
714-731
scripts/slave/recipe_modules/chromium_android/example 57 52 9%
73-158, 161-186
scripts/slave/recipe_modules/chromium_tests/api 249 17 93%
264-267, 395-402, 580, 588-590, 612, 619
scripts/slave/recipe_modules/chromium_tests/example 14 11 21%
16-35, 40-71
scripts/slave/recipe_modules/commit_position/api 44 8 82%
24-25, 34-35, 44-45, 67-68
scripts/slave/recipe_modules/commit_position/example 31 24 23%
19-49, 53-75
scripts/slave/recipe_modules/cronet/example 18 13 28%
27-37, 40-48
scripts/slave/recipe_modules/disk/api 28 25 11%
33-74
scripts/slave/recipe_modules/disk/example 20 16 20%
16-37, 43-59
scripts/slave/recipe_modules/disk/test_api 5 2 60%
10-11
scripts/slave/recipe_modules/file/api 21 7 67%
16, 30, 44-47, 52
scripts/slave/recipe_modules/file/example 26 21 19%
26-57, 61
scripts/slave/recipe_modules/filter/api 86 18 79%
109, 118, 122, 155-165, 168-169, 172-173, 176-178, 180
scripts/slave/recipe_modules/filter/example 25 22 12%
17-34, 38-159
scripts/slave/recipe_modules/gclient/api 130 15 88%
67, 93, 97, 115, 155-160, 226-234, 273
scripts/slave/recipe_modules/gclient/example 22 19 14%
11-36, 39
scripts/slave/recipe_modules/gclient/test_api 11 1 91%
34
scripts/slave/recipe_modules/generator_script/api 41 38 7%
27-81
scripts/slave/recipe_modules/generator_script/example 11 8 27%
15-18, 21-55
scripts/slave/recipe_modules/generator_script/test_api 5 2 60%
5-6
scripts/slave/recipe_modules/git/api 131 78 40%
20, 25-29, 33-35, 40-42, 57-107, 141-148, 156, 161, 184-186, 191-198, 202,
207-208, 212, 224, 232, 244-252, 274-277, 290-297
scripts/slave/recipe_modules/git/example 35 32 9%
16-63, 67-123
scripts/slave/recipe_modules/git/test_api 4 1 75%
9
scripts/slave/recipe_modules/gitiles/api 23 16 30%
13-19, 23-30, 44-60, 72-76
scripts/slave/recipe_modules/gitiles/example 8 5 38%
12-15, 19
scripts/slave/recipe_modules/gitiles/test_api 8 3 63%
9, 12, 15
scripts/slave/recipe_modules/goma/example 5 2 60%
10, 14
scripts/slave/recipe_modules/gpu/api 170 88 48%
34-101, 118-127, 135-144, 164, 167-168, 172-232, 238-241, 266, 289-290, 300-305,
315-316, 371, 426, 433-436, 447, 517-520, 522
scripts/slave/recipe_modules/gpu/test_api 11 3 73%
22, 30, 38
scripts/slave/recipe_modules/gsutil/api 95 38 60%
68-72, 90-100, 106-110, 113-117, 133-140, 148-151, 170-187
scripts/slave/recipe_modules/gsutil/example 18 15 17%
13-46, 53
scripts/slave/recipe_modules/ios/api 92 79 14%
10-11, 15-31, 35-37, 41-42, 46-47, 51-55, 64-113, 127-174, 182-256, 263-273,
282-305
scripts/slave/recipe_modules/ios/test_api 17 6 65%
12, 15, 20, 23, 26, 38
scripts/slave/recipe_modules/isolate/api 79 18 77%
24, 42, 89-99, 105, 172-178, 247, 271-273, 277-282
scripts/slave/recipe_modules/isolate/example 25 22 12%
17-41, 45-70
scripts/slave/recipe_modules/json/api 54 3 94%
37, 78-79
scripts/slave/recipe_modules/json/example 8 5 38%
12-17, 21
scripts/slave/recipe_modules/json/test_api 12 4 67%
12-15
scripts/slave/recipe_modules/libyuv/api 4 1 75%
9
scripts/slave/recipe_modules/omahaproxy/api 19 13 32%
16-18, 21-36
scripts/slave/recipe_modules/path/api 120 8 93%
48, 179, 257-258, 280-284
scripts/slave/recipe_modules/path/example 16 13 19%
13-34, 39-42
scripts/slave/recipe_modules/path/test_api 13 6 54%
8-9, 12, 15-17
scripts/slave/recipe_modules/perf_dashboard/api 20 11 45%
15-18, 43-52, 60, 64
scripts/slave/recipe_modules/perf_dashboard/example 16 13 19%
20-36, 39-41
scripts/slave/recipe_modules/pgo/api 38 30 21%
36, 43-48, 55-69, 76-89, 97-121
scripts/slave/recipe_modules/properties/api 15 1 93%
37
scripts/slave/recipe_modules/properties/example 9 5 44%
10-11, 14-18
scripts/slave/recipe_modules/properties/test_api 22 3 86%
44-51
scripts/slave/recipe_modules/raw_io/api 77 4 95%
59-60, 98-99
scripts/slave/recipe_modules/raw_io/example 18 15 17%
14-56, 61
scripts/slave/recipe_modules/repo/api 28 17 39%
18-19, 23-25, 29, 33-34, 41-46, 52-53, 60
scripts/slave/recipe_modules/repo/example 10 7 30%
11-16, 20
scripts/sla…
(message too large)
alexmos@chromium.org changed reviewers: + iannucci@chromium.org
iannucci@: do you mind taking a look at this CL and why it may be failing CQ
presubmit checks (which pass locally)? hinoka@ suggested asking you while he's
busy.
We're trying to add a trybot that would run tests with the --site-per-process
flag, similarly to our site isolation FYI bots. I was hoping we can reuse the
same recipe as our Linux FYI bot ("Site Isolation Linux" in chromium.fyi.json).
The syntax of this file has changed since the patch was created. You need to rebase and adjust the patch accordingly (everything is based on the main waterfall now).
On 2015/03/02 18:36:11, iannucci wrote: > The syntax of this file has changed since the patch was created. You need to > rebase and adjust the patch accordingly (everything is based on the main > waterfall now). Thanks! Rebased and updated syntax in PS4.
On 2015/03/02 21:05:41, alexmos wrote: > On 2015/03/02 18:36:11, iannucci wrote: > > The syntax of this file has changed since the patch was created. You need to > > rebase and adjust the patch accordingly (everything is based on the main > > waterfall now). > > Thanks! Rebased and updated syntax in PS4. fwiw, rs-lgtm to land :)
The CQ bit was checked by alexmos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org Link to the patchset: https://codereview.chromium.org/943113002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943113002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294282 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
