Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: shell/application_manager/shell_impl.h

Issue 943053003: Simple multi-url support for mojo apps (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/application_manager/shell_impl.h
diff --git a/shell/application_manager/shell_impl.h b/shell/application_manager/shell_impl.h
index 1748078911256b1a28dfbc49cdfe97c08f27443f..70d6a963d1c12ebd7d24e12349d0d4bed25d1a05 100644
--- a/shell/application_manager/shell_impl.h
+++ b/shell/application_manager/shell_impl.h
@@ -16,22 +16,30 @@ class ApplicationManager;
class ShellImpl : public Shell, public ErrorHandler {
public:
+ enum QueryHandlingBehavior {
qsr 2015/02/27 15:01:41 Can you comment on this, and on what behavior it d
Aaron Boodman 2015/02/27 16:54:44 removed.
+ SHELL_DOES_NOT_HANDLE_QUERY,
+ SHELL_HANDLES_QUERY,
+ };
+
ShellImpl(ApplicationPtr application,
ApplicationManager* manager,
const GURL& requested_url,
- const GURL& url);
+ const GURL& url,
+ QueryHandlingBehavior query_behavior);
~ShellImpl() override;
void InitializeApplication(Array<String> args);
- void ConnectToClient(const GURL& requestor_url,
+ void ConnectToClient(const GURL& requested_url,
+ const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services);
Application* application() { return application_.get(); }
const GURL& url() const { return url_; }
const GURL& requested_url() const { return requested_url_; }
+ bool handles_query() const { return handles_query_; }
qsr 2015/02/27 15:01:41 As discussed offline, this is not necessary.
Aaron Boodman 2015/02/27 16:54:44 agree, done.
private:
// Shell implementation:
@@ -48,6 +56,9 @@ class ShellImpl : public Shell, public ErrorHandler {
ApplicationPtr application_;
Binding<Shell> binding_;
+ // If true, this shell will handle connections to url_ with any querystring.
+ bool handles_query_;
+
DISALLOW_COPY_AND_ASSIGN(ShellImpl);
};

Powered by Google App Engine
This is Rietveld 408576698