Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: examples/forwarding_content_handler/forwarding_content_handler.cc

Issue 943053003: Simple multi-url support for mojo apps (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/forwarding_content_handler/forwarding_content_handler.cc
diff --git a/examples/forwarding_content_handler/forwarding_content_handler.cc b/examples/forwarding_content_handler/forwarding_content_handler.cc
index 6f4275bba75401f849956743c814c8482fb40e0b..5c75320e3a726bac49ae76a567a7034f5cf24f1e 100644
--- a/examples/forwarding_content_handler/forwarding_content_handler.cc
+++ b/examples/forwarding_content_handler/forwarding_content_handler.cc
@@ -23,9 +23,7 @@ class ForwardingApplicationImpl : public Application {
public:
ForwardingApplicationImpl(InterfaceRequest<Application> request,
std::string target_url)
qsr 2015/02/27 15:01:40 I don't understand this change. This content hand
Aaron Boodman 2015/02/27 16:54:44 Whoopsie. fixed.
- : binding_(this, request.Pass()),
- target_url_(target_url) {
- }
+ : binding_(this, request.Pass()) {}
private:
// Application:
@@ -36,16 +34,15 @@ class ForwardingApplicationImpl : public Application {
}
void AcceptConnection(const String& requestor_url,
InterfaceRequest<ServiceProvider> services,
- ServiceProviderPtr exposed_services) override {
- shell_->ConnectToApplication(target_url_, services.Pass(),
- exposed_services.Pass());
+ ServiceProviderPtr exposed_services,
+ const String& url) override {
+ shell_->ConnectToApplication(url, services.Pass(), exposed_services.Pass());
}
void RequestQuit() override {
RunLoop::current()->Quit();
}
Binding<Application> binding_;
- std::string target_url_;
ShellPtr shell_;
};

Powered by Google App Engine
This is Rietveld 408576698