Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: shell/application_manager/application_manager.h

Issue 943053003: Simple multi-url support for mojo apps (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase + fix android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/application_manager/application_manager.h
diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index 9e3da2d97c769a945fdaa7683ddec717a2434401..cce6089b97ae4fe8278903e398cca90941087015 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -150,7 +150,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
typedef std::map<GURL, std::vector<std::string>> URLToArgsMap;
typedef std::map<std::string, GURL> MimeTypeToURLMap;
- bool ConnectToRunningApplication(const GURL& application_url,
+ bool ConnectToRunningApplication(const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider>* services,
ServiceProviderPtr* exposed_services);
@@ -164,7 +164,11 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
ApplicationLoader* loader);
InterfaceRequest<Application> RegisterShell(
- const GURL& requested_url,
+ // The original URL requested by client, before any resolution or
+ // redirects.
+ // This is mostly useless and should be removed.
+ const GURL& original_url,
+ // The URL after resolution and redirects, including the querystring.
const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
@@ -173,7 +177,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
ShellImpl* GetShellImpl(const GURL& url);
void ConnectToClient(ShellImpl* shell_impl,
- const GURL& url,
+ const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services);

Powered by Google App Engine
This is Rietveld 408576698