Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 943043004: Revert of Enable ServiceWorkerMicroBenchmarkPerfTest (service_worker.service_worker_micro_benchmark) (Closed)

Created:
5 years, 10 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
Reviewers:
falken, nednguyen, sullivan, horo
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable ServiceWorkerMicroBenchmarkPerfTest (service_worker.service_worker_micro_benchmark) (patchset #1 id:1 of https://codereview.chromium.org/951223002/) Reason for revert: This immediately re-introduced redness on the tree: http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20(2) http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%282%29/builds/3993 Original issue's description: > Enable ServiceWorkerMicroBenchmarkPerfTest (service_worker.service_worker_micro_benchmark) > > I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness. > > BUG=442752 > TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker_micro_benchmark > > Committed: https://crrev.com/79b35fe9bc28e4e1a2a10ce26edc5d8b46fb362f > Cr-Commit-Position: refs/heads/master@{#317805} TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=442752 Committed: https://crrev.com/65534e46894bbd9593e8ccccf5ace38cab750115 Cr-Commit-Position: refs/heads/master@{#317896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
Created Revert of Enable ServiceWorkerMicroBenchmarkPerfTest (service_worker.service_worker_micro_benchmark)
5 years, 10 months ago (2015-02-24 21:56:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943043004/1
5 years, 10 months ago (2015-02-24 21:57:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 21:58:01 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 22:01:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65534e46894bbd9593e8ccccf5ace38cab750115
Cr-Commit-Position: refs/heads/master@{#317896}

Powered by Google App Engine
This is Rietveld 408576698