Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 943043002: Revert of sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org, caitkp+watch_chromium.org, Mark Seaborn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG (patchset #3 id:40001 of https://codereview.chromium.org/921353002/) Reason for revert: Speculative revert after discussion on IRC, this seems pretty unlikely but may have caused the failures at: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35506 Original issue's description: > sandbox: Fix some nt_internals.h function prototypes for Win64 > > NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes. > > NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes. > > DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change. > > R=robertshield@chromium.org,rvargas@chromium.org > BUG=458690 > > Committed: https://crrev.com/4ede4e174a51d08262edfb2e2c05845504bd9b1a > Cr-Commit-Position: refs/heads/master@{#317177} TBR=jschuh@chromium.org,robertshield@chromium.org,thakis@chromium.org,wfh@chromium.org,rvargas@chromium.org,rnk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458690 Committed: https://crrev.com/faeb8f6a5524dded1f97c16dee4b09dce548bae4 Cr-Commit-Position: refs/heads/master@{#317409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome_elf/blacklist/blacklist_interceptions.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sandbox/win/src/nt_internals.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/win/src/sandbox_nt_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
JF
Created Revert of sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG
5 years, 10 months ago (2015-02-20 21:45:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943043002/1
5 years, 10 months ago (2015-02-20 21:46:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 21:47:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/faeb8f6a5524dded1f97c16dee4b09dce548bae4 Cr-Commit-Position: refs/heads/master@{#317409}
5 years, 10 months ago (2015-02-20 21:47:57 UTC) #4
JF
I should have added: BUG= https://code.google.com/p/chromium/issues/detail?id=460563
5 years, 10 months ago (2015-02-20 21:51:14 UTC) #5
JF
5 years, 10 months ago (2015-02-21 02:08:49 UTC) #6
Message was sent while issue was closed.
The build was fixed after this revert:
  http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)

Specific build:
 
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...

I'm calling this CL the culprit :-)

Powered by Google App Engine
This is Rietveld 408576698