Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 943033004: Add the new files from https://webrtc-codereview.appspot.com/37889004/ to libjingle.gyp (Closed)

Created:
5 years, 10 months ago by jiayl
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the new files from https://webrtc-codereview.appspot.com/37889004/ to libjingle.gyp BUG=webrtc:4241 Committed: https://crrev.com/5bfb976c6c589c601d8c9dc03cf9a7668d2bfb6b Cr-Commit-Position: refs/heads/master@{#317604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jiayl
PTAL
5 years, 10 months ago (2015-02-20 23:48:15 UTC) #2
tommi (sloooow) - chröme
Lgtm. Will you land this with a roll?
5 years, 10 months ago (2015-02-21 07:39:32 UTC) #3
lyubenahristova
On 2015/02/20 23:48:14, jiayl wrote: > mailto:jiayl@chromium.org<font><font class=""> geändert Rezensenten:</font></font><font></font><font><font class=""> > + </font></font>mailto:tommi@chromium.org
5 years, 10 months ago (2015-02-21 07:45:43 UTC) #4
lyubenahristova
lgtm
5 years, 10 months ago (2015-02-21 09:11:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943033004/1
5 years, 10 months ago (2015-02-23 16:54:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 17:51:59 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:52:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bfb976c6c589c601d8c9dc03cf9a7668d2bfb6b
Cr-Commit-Position: refs/heads/master@{#317604}

Powered by Google App Engine
This is Rietveld 408576698