sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart - Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart ('k') | sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart (revision 30754)

+++ sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart (working copy)

@@ -634,7 +634,7 @@

}

Range visitInstruction(HInstruction instruction) {

- if (instruction.isUInt32(compiler)) {

+ if (instruction.isPositiveInteger(compiler)) {

return info.newNormalizedRange(

info.intZero, info.newPositiveValue(instruction));

} else if (instruction.isInteger(compiler)) {

@@ -824,7 +824,7 @@

Range visitCheck(HCheck instruction) {

if (ranges[instruction.checkedInput] == null) {

- return info.newUnboundRange();

+ return visitInstruction(instruction);

}

return ranges[instruction.checkedInput];

}