sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart - Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart ('k') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart (revision 30754)

+++ sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart (working copy)

@@ -76,6 +76,7 @@

TypeMask get intType => compiler.typesTask.intType;

TypeMask get uint32Type => compiler.typesTask.uint32Type;

TypeMask get uint31Type => compiler.typesTask.uint31Type;

+ TypeMask get positiveIntType => compiler.typesTask.positiveIntType;

TypeMask get doubleType => compiler.typesTask.doubleType;

TypeMask get numType => compiler.typesTask.numType;

TypeMask get boolType => compiler.typesTask.boolType;

@@ -684,7 +685,7 @@

T indexType;

if (isIncrementOrDecrement) {

- rhsType = types.intType;

+ rhsType = types.uint31Type;

if (node.isIndex) indexType = visit(node.arguments.head);

} else if (node.isIndex) {

indexType = visit(node.arguments.head);