sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart - Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart

Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart ('k') | sdk/lib/_internal/compiler/implementation/types/types.dart » ('j') | sdk/lib/_internal/lib/js_number.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart (revision 30705)

+++ sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart (working copy)

@@ -99,7 +99,8 @@

return cls == compiler.intClass

|| cls == backend.intImplementation

|| cls == backend.uint32Implementation

- || cls == backend.uint31Implementation;

+ || cls == backend.uint31Implementation

+ || cls == backend.positiveIntImplementation;

kasperl 2013/11/28 09:09:47 Move up to have the same order as in the method be

ngeoffray 2013/11/28 11:21:47 Done.

}

if (containsOnlyDouble(compiler)) {

return cls == compiler.doubleClass

@@ -136,6 +137,7 @@

bool containsOnlyInt(Compiler compiler) {

return base == compiler.intClass

|| base == compiler.backend.intImplementation

+ || base == compiler.backend.positiveIntImplementation

|| base == compiler.backend.uint31Implementation

|| base == compiler.backend.uint32Implementation;

}