sdk/lib/_internal/compiler/implementation/constants.dart - Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/constants.dart

Issue 94303002: Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart » ('j') | sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/constants.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/constants.dart (revision 30705)

+++ sdk/lib/_internal/compiler/implementation/constants.dart (working copy)

@@ -164,6 +164,7 @@

bool isInt() => true;

bool isUInt31() => value >= 0 && value < (1 << 31);

bool isUInt32() => value >= 0 && value < (1 << 32);

+ bool isPositive() => value >= 0;

kasperl 2013/11/28 09:09:47 Stephen would probably insist on this being isNonN

DartType computeType(Compiler compiler) {

return compiler.intClass.computeType(compiler);

@@ -172,6 +173,7 @@

ti.TypeMask computeMask(Compiler compiler) {

if (isUInt31()) return compiler.typesTask.uint31Type;

if (isUInt32()) return compiler.typesTask.uint32Type;

+ if (isPositive()) return compiler.typesTask.positiveIntType;

return compiler.typesTask.intType;

}