Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 943023002: Only require iOS ninja bots on the commit queue (Closed)

Created:
5 years, 10 months ago by smut
Modified:
5 years, 10 months ago
Reviewers:
stuartmorgan, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only require iOS ninja bots on the commit queue This also makes the two iOS ninja bots the default "git cl try" bots for iOS CLs. BUG=457659

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M PRESUBMIT.py View 1 chunk +4 lines, -1 line 0 comments Download
M testing/commit_queue/config.json View 1 chunk +2 lines, -15 lines 3 comments Download

Messages

Total messages: 7 (1 generated)
smut
Will convert to ng when it's working (it's borked for simulator). For now let's use ...
5 years, 10 months ago (2015-02-20 20:55:40 UTC) #2
jam
lgtm, thanks
5 years, 10 months ago (2015-02-20 21:38:26 UTC) #3
stuartmorgan
lgtm
5 years, 10 months ago (2015-02-20 22:15:02 UTC) #4
jam
https://codereview.chromium.org/943023002/diff/1/testing/commit_queue/config.json File testing/commit_queue/config.json (right): https://codereview.chromium.org/943023002/diff/1/testing/commit_queue/config.json#newcode76 testing/commit_queue/config.json:76: "ios_rel_device_ninja": ["defaulttests"] actually, what do we gain from switching ...
5 years, 10 months ago (2015-02-21 00:14:12 UTC) #5
jam
https://codereview.chromium.org/943023002/diff/1/testing/commit_queue/config.json File testing/commit_queue/config.json (right): https://codereview.chromium.org/943023002/diff/1/testing/commit_queue/config.json#newcode76 testing/commit_queue/config.json:76: "ios_rel_device_ninja": ["defaulttests"] On 2015/02/21 00:14:12, jam wrote: > actually, ...
5 years, 10 months ago (2015-02-23 15:14:30 UTC) #6
smut
5 years, 10 months ago (2015-02-23 18:33:28 UTC) #7
https://codereview.chromium.org/943023002/diff/1/testing/commit_queue/config....
File testing/commit_queue/config.json (right):

https://codereview.chromium.org/943023002/diff/1/testing/commit_queue/config....
testing/commit_queue/config.json:76: "ios_rel_device_ninja": ["defaulttests"]
On 2015/02/21 00:14:12, jam wrote:
> actually, what do we gain from switching to ios_rel_device_ninja from
> ios_rel_device_ng?
> 
> ios_rel_device_ninja bot appears to use a recipe that doesn't support
> analyze.py, from looking at https://codereview.chromium.org/942953002/. So
this
> would be a regression.

I'll add an analyze.py step to these bots.

Powered by Google App Engine
This is Rietveld 408576698