sky/engine/bindings/scripts/templates/attributes_cpp.template - Issue 943013002: Implement Custom Elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/templates/attributes_cpp.template

Issue 943013002: Implement Custom Elements (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: attributeChanged***d***Callback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/templates/attributes_cpp.template

diff --git a/sky/engine/bindings/scripts/templates/attributes_cpp.template b/sky/engine/bindings/scripts/templates/attributes_cpp.template

index cc0184087c4041bb18f2d9a43c204833c1e93895..6df30964262bb21d68c867264f3a1527609269d3 100644

--- a/sky/engine/bindings/scripts/templates/attributes_cpp.template

+++ b/sky/engine/bindings/scripts/templates/attributes_cpp.template

@@ -83,7 +83,7 @@ static void {{static_attribute_name(attribute, 'Setter')}}(Dart_NativeArguments

{

{{cpp_class}}* receiver = GetReceiver<{{cpp_class}}>(args);

{% if attribute.is_custom_element_callbacks %}

- CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;

+ NewCustomElementCallbackScope deliveryScope;

{% endif %}

{% set attribute_name = attribute.name if not attribute.put_forwards else 'value' %}