Issue 942993002: Add support for |any| to Sky's code generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 942993002: Add support for |any| to Sky's code generator (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add support for |any| to Sky's code generator We now expand |any| to DartValue (which exists) as opposed to ScriptValue (which does not). Also, fill in a few missing pieces in tonic that will be used by custom elements. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/184086201aa8b086d99b673bfad9333ef69959ee

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -17 lines)			Patch
M	sky/engine/bindings/scripts/dart_types.py	View	11 chunks	+13 lines, -15 lines	0 comments	Download
M	sky/engine/tonic/dart_converter.h	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	sky/engine/tonic/dart_state.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sky/engine/tonic/dart_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/tonic/dart_value.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 10 months ago (2015-02-20 20:19:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
184086201aa8b086d99b673bfad9333ef69959ee (presubmit successful).