Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 942973002: Revert of Test that visual state callbacks do not deadlock. (Closed)

Created:
5 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@breakSwapIfNoUpdates
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Test that visual state callbacks do not deadlock. (patchset #6 id:100001 of https://codereview.chromium.org/939673002/) Reason for revert: Timing out on Blink waterfall. See https://code.google.com/p/chromium/issues/detail?id=458577#c10 . Original issue's description: > Test that visual state callbacks do not deadlock. > > Visual state callbacks should always be received, > even if there are no pending commits. We add > a test for that. See crbug/458577 for more details. > > BUG=458577 > > Committed: https://crrev.com/dcc18cb569b31bc07c97d49573e695ec8b1f80c0 > Cr-Commit-Position: refs/heads/master@{#317306} TBR=piman@chromium.org,sievers@chromium.org,skyostil@chromium.org,igsolla@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458577 Committed: https://crrev.com/5b5697022d789ef3e6f08e687d23a0248d75d8ba Cr-Commit-Position: refs/heads/master@{#317381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -115 lines) Patch
M content/content_tests.gypi View 4 chunks +4 lines, -5 lines 0 comments Download
D content/renderer/visual_state_browsertest.cc View 1 chunk +0 lines, -110 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Test that visual state callbacks do not deadlock.
5 years, 10 months ago (2015-02-20 20:00:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942973002/1
5 years, 10 months ago (2015-02-20 20:01:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:02:37 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:03:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b5697022d789ef3e6f08e687d23a0248d75d8ba
Cr-Commit-Position: refs/heads/master@{#317381}

Powered by Google App Engine
This is Rietveld 408576698