src/ic/ic.cc - Issue 942963004: Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 942963004: Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove the distinction between named/indexed access checks, always pass "undefined" as "name" Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index ef8e069fda99301efa30c9223af4253e221a7442..d4a0e7251b13dd4eac56836f978c0cefb7a24a43 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -249,8 +249,7 @@ static void LookupForRead(LookupIterator* it) {

case LookupIterator::ACCESS_CHECK:

// PropertyHandlerCompiler::CheckPrototypes() knows how to emit

// access checks for global proxies.

- if (it->GetHolder<JSObject>()->IsJSGlobalProxy() &&

- it->HasAccess(v8::ACCESS_GET)) {

+ if (it->GetHolder<JSObject>()->IsJSGlobalProxy() && it->HasAccess()) {

break;

}

return;

« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »