Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 942953002: Add iOS try bots using the new iOS try bot recipe (Closed)

Created:
5 years, 10 months ago by smut
Modified:
5 years, 10 months ago
Reviewers:
lliabraa
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Add iOS try bots using the new iOS try bot recipe This adds xcodebuild and ninja bots for simulator/debug and release/device to the try server, using the new canonical iOS try bot recipe. BUG=457659 R=lliabraa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294147

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M masters/master.tryserver.chromium.mac/master.cfg View 2 chunks +19 lines, -1 line 0 comments Download
M masters/master.tryserver.chromium.mac/slaves.cfg View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.py View 1 chunk +1 line, -5 lines 2 comments Download
M scripts/slave/recipes/ios/try.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/parent.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
smut
Per discussion on bug, converting iOS bots to the new recipe, and adding ios_simulator_dbg_ninja. https://codereview.chromium.org/942953002/diff/1/scripts/slave/recipes/ios/try.py ...
5 years, 10 months ago (2015-02-20 19:42:10 UTC) #2
lliabraa
lgtm https://codereview.chromium.org/942953002/diff/1/scripts/slave/recipes/ios/try.py File scripts/slave/recipes/ios/try.py (left): https://codereview.chromium.org/942953002/diff/1/scripts/slave/recipes/ios/try.py#oldcode18 scripts/slave/recipes/ios/try.py:18: api.ios.read_build_config(master_name='chromium.mac') On 2015/02/20 19:42:10, smut wrote: > I ...
5 years, 10 months ago (2015-02-20 20:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942953002/1
5 years, 10 months ago (2015-02-20 20:30:38 UTC) #5
commit-bot: I haz the power
Presubmit check for 942953002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 10 months ago (2015-02-20 20:33:30 UTC) #7
smut
5 years, 10 months ago (2015-02-20 20:35:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 294147.

Powered by Google App Engine
This is Rietveld 408576698