Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: sky/engine/core/editing/htmlediting.cpp

Issue 942933003: Remove almost all clients of isHTMLElement (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/editing/htmlediting.h ('k') | sky/engine/core/html/HTMLElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/editing/htmlediting.cpp
diff --git a/sky/engine/core/editing/htmlediting.cpp b/sky/engine/core/editing/htmlediting.cpp
index 369121b493b67211a8808d953aca44fbdbdb012e..9ab7639ddea059a69f12502620291dcaebb26f1a 100644
--- a/sky/engine/core/editing/htmlediting.cpp
+++ b/sky/engine/core/editing/htmlediting.cpp
@@ -390,7 +390,7 @@ bool isSpecialHTMLElement(const Node* n)
if (!n)
return false;
- if (!n->isHTMLElement())
+ if (!n->isElementNode())
return false;
if (n->isLink())
@@ -608,7 +608,7 @@ Element* enclosingAnchorElement(const Position& p)
bool canMergeLists(Element* firstList, Element* secondList)
{
- if (!firstList || !secondList || !firstList->isHTMLElement() || !secondList->isHTMLElement())
+ if (!firstList || !secondList)
return false;
return firstList->hasTagName(secondList->tagQName()) // make sure the list types match (ol vs. ul)
@@ -633,16 +633,6 @@ PassRefPtr<HTMLElement> createDefaultParagraphElement(Document& document)
return nullptr;
}
-PassRefPtr<HTMLElement> createHTMLElement(Document& document, const QualifiedName& name)
-{
- return createHTMLElement(document, name.localName());
-}
-
-PassRefPtr<HTMLElement> createHTMLElement(Document& document, const AtomicString& tagName)
-{
- return HTMLElementFactory::createHTMLElement(tagName, document, false);
-}
-
bool isNodeRendered(const Node *node)
{
return node && node->renderer();
« no previous file with comments | « sky/engine/core/editing/htmlediting.h ('k') | sky/engine/core/html/HTMLElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698