Issue 942933003: Remove almost all clients of isHTMLElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 942933003: Remove almost all clients of isHTMLElement (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove almost all clients of isHTMLElement This CL is progress towards deleting the concept of an HTMLElement entirely. We won't actually get all the way there in this CL series, but we're getting closer. This CL also will let us make custom elements just be Elements instead of HTMLElements. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/28d9211c0e0fa7d971a6c89bd8f6c536a080209a

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -68 lines)			Patch
M	sky/engine/build/scripts/templates/ElementFactory.cpp.tmpl	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	sky/engine/build/scripts/templates/ElementFactory.h.tmpl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Element.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/dom/Node.h	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	sky/engine/core/dom/Node.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/editing/ApplyBlockElementCommand.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/editing/ApplyBlockElementCommand.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/editing/EditingStyle.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/editing/EditingStyle.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/editing/ReplaceSelectionCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/editing/htmlediting.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/editing/htmlediting.cpp	View	3 chunks	+2 lines, -12 lines	0 comments	Download
M	sky/engine/core/html/HTMLElement.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLConstructionSite.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLConstructionSite.cpp	View	4 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 10 months ago (2015-02-20 20:06:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
28d9211c0e0fa7d971a6c89bd8f6c536a080209a (presubmit successful).

Expand Messages | Collapse Messages