public/platform/modules/app_banner/WebAppBannerPromptReply.h - Issue 942913002: [AppBanner] Blink implementation of an event when an install banner is shown.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/platform/modules/app_banner/WebAppBannerPromptReply.h

Issue 942913002: [AppBanner] Blink implementation of an event when an install banner is shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebAppBannerPromptReply_h

	6 #define WebAppBannerPromptReply_h

	7

	8 namespace blink {

	9

	10 enum class WebAppBannerPromptReply {

	11 None = 0,
	Mike West 2015/03/06 20:17:45 Nit: WebAppBannerPromptReplyNone and WebAppBannerP Nit: WebAppBannerPromptReplyNone and WebAppBannerPromptReplyCancel. mlamouri (slow - plz ping) 2015/03/06 20:42:04 With "enum class", AFAIK, you would have to do Web Show quoted text On 2015/03/06 at 20:17:45, Mike West wrote: > Nit: WebAppBannerPromptReplyNone and WebAppBannerPromptReplyCancel. With "enum class", AFAIK, you would have to do WebAppBannerPromptReply::WebAppBannerPromptReplyNone (see AppBannerController.cpp). It seems that other WebKit "enum class" follow the same pattern: https://code.google.com/p/chromium/codesearch#search/&sq=package:chromium&q=%...
	12 Cancel

	13 };

	14

	15 } // namespace blink

	16

	17 #endif // WebAppBannerPromptReply_h

OLD	NEW

« no previous file with comments | « public/platform/modules/app_banner/OWNERS ('k') | public/web/WebLocalFrame.h » ('j') | no next file with comments »