Source/modules/app_banner/BeforeInstallPromptEvent.idl - Issue 942913002: [AppBanner] Blink implementation of an event when an install banner is shown.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/app_banner/BeforeInstallPromptEvent.idl

Issue 942913002: [AppBanner] Blink implementation of an event when an install banner is shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/app_banner/AppBannerController.h ('K') | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | Source/modules/app_banner/BeforeInstallPromptEventInit.idl » ('j') | Source/modules/app_banner/OWNERS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 Constructor(DOMString platform, optional BeforeInstallPromptEventInit eventI nitDict),

	7 RuntimeEnabled=AppBanner,

	8 ] interface BeforeInstallPromptEvent : Event {

	9 readonly attribute DOMString platform;

	10 [CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;
	Mike West 2015/03/06 14:30:29 Are we informing the site whether or not the user Are we informing the site whether or not the user installed the app? (Skimming https://github.com/slightlyoff/AppInstallImprovements/blob/master/explainer.md, I guess we are). Doesn't that invite bad behavior? mlamouri (slow - plz ping) 2015/03/06 18:50:47 For now, this is not implemented. I believe there Show quoted text On 2015/03/06 at 14:30:29, Mike West wrote: > Are we informing the site whether or not the user installed the app? (Skimming https://github.com/slightlyoff/AppInstallImprovements/blob/master/explainer.md, I guess we are). Doesn't that invite bad behavior? For now, this is not implemented. I believe there are some discussions about this and I'm pretty sure the implementation will stay in sync.
	11 };

OLD	NEW