Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 942893002: Remove now unnecessary test_isolation_fail_on_missing gyp variable. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now unnecessary test_isolation_fail_on_missing gyp variable. BUG=395700 Committed: https://crrev.com/27c183a5072be788a1059c30419e93b96b410685 Cr-Commit-Position: refs/heads/master@{#317345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M build/isolate.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 10 months ago (2015-02-20 16:44:15 UTC) #2
M-A Ruel
awesome, thanks. lgtm
5 years, 10 months ago (2015-02-20 16:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942893002/1
5 years, 10 months ago (2015-02-20 17:03:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 17:40:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 17:40:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27c183a5072be788a1059c30419e93b96b410685
Cr-Commit-Position: refs/heads/master@{#317345}

Powered by Google App Engine
This is Rietveld 408576698