Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 942873002: Upstream Tab's audio/video capturing APIs to ChromeWebContentsDelegateAndroid (Closed)

Created:
5 years, 10 months ago by Yaron
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Tab's audio/video capturing APIs to ChromeWebContentsDelegateAndroid This is a little icky but probably better than just putting it in Tab. It seems like MediaCaptureDevicesDispatcher could have its own JNI wrapper but it would be quite thin. At least this way, the accesses are co-located. BUG=443773 Committed: https://crrev.com/fd6f8f6532cd0d6b1c97ec28945ed0b9c2f974f6 Cr-Commit-Position: refs/heads/master@{#317585}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yaron
min: is there a better place for this within media?
5 years, 10 months ago (2015-02-20 16:08:31 UTC) #2
qinmin
lgtm https://codereview.chromium.org/942873002/diff/1/chrome/browser/android/chrome_web_contents_delegate_android.cc File chrome/browser/android/chrome_web_contents_delegate_android.cc (right): https://codereview.chromium.org/942873002/diff/1/chrome/browser/android/chrome_web_contents_delegate_android.cc#newcode352 chrome/browser/android/chrome_web_contents_delegate_android.cc:352: jboolean IsCapturingAudio(JNIEnv* env, is there a way to ...
5 years, 10 months ago (2015-02-20 18:34:59 UTC) #3
David Trainor- moved to gerrit
lgtm
5 years, 10 months ago (2015-02-20 19:42:35 UTC) #4
Yaron
https://chromiumcodereview.appspot.com/942873002/diff/1/chrome/browser/android/chrome_web_contents_delegate_android.cc File chrome/browser/android/chrome_web_contents_delegate_android.cc (right): https://chromiumcodereview.appspot.com/942873002/diff/1/chrome/browser/android/chrome_web_contents_delegate_android.cc#newcode352 chrome/browser/android/chrome_web_contents_delegate_android.cc:352: jboolean IsCapturingAudio(JNIEnv* env, On 2015/02/20 18:34:59, qinmin wrote: > ...
5 years, 10 months ago (2015-02-23 14:26:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942873002/20001
5 years, 10 months ago (2015-02-23 14:28:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 14:50:09 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 14:51:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd6f8f6532cd0d6b1c97ec28945ed0b9c2f974f6
Cr-Commit-Position: refs/heads/master@{#317585}

Powered by Google App Engine
This is Rietveld 408576698