tools/chrome_proxy/integration_tests/network_metrics.py - Issue 942863004: Integration test for “lo-fi” mode in Chrome-Proxy request header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/network_metrics.py

Issue 942863004: Integration test for “lo-fi” mode in Chrome-Proxy request header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py ('K') | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/network_metrics.py

diff --git a/tools/chrome_proxy/integration_tests/network_metrics.py b/tools/chrome_proxy/integration_tests/network_metrics.py

index 9c41dcce37d83164f4e227a54418ff52e1ed40a6..1af12607b6fef295128b317c91f21515a78258c6 100644

--- a/tools/chrome_proxy/integration_tests/network_metrics.py

+++ b/tools/chrome_proxy/integration_tests/network_metrics.py

@@ -98,9 +98,10 @@ class HTTPResponse(object):

try:

cl = self.GetContentLengthFromBody()

except Exception, e:

- resp = self.response

logging.warning('Fail to get content length for %s from body: %s',

- resp.url[:100], e)

+ self.response.url[:100], e)

+ if cl == 0:

+ resp = self.response

cl_header = resp.GetHeader('Content-Length')

if cl_header:

cl = int(cl_header)

@@ -170,7 +171,7 @@ class NetworkMetric(Metric):

ocl = resp.original_content_length

if ocl < cl:

logging.warning('original content length (%d) is less than content '

- 'lenght(%d) for resource %s', ocl, cl, resource)

+ 'length (%d) for resource %s', ocl, cl, resource)

if self.add_result_for_resource:

results.AddValue(scalar.ScalarValue(

results.current_page,