Integration test for “lo-fi” mode in Chrome-Proxy request header

Integration test for “lo-fi” mode in Chrome-Proxy request header

A telemetry test that checks for "q=low" in the Chrome-Proxy
request header and verifies that the image received was less than 100 bytes.

BUG=449665
Committed: https://crrev.com/d2e455390173cf46497d048f796a7d907e445c47
Cr-Commit-Position: refs/heads/master@{#318926}

[megjablon, 2015-02-20 23:08:02]

Patchset #1 (id:1) has been deleted

[megjablon, 2015-02-27 00:05:41]

Patchset #1 (id:20001) has been deleted

[megjablon, 2015-02-27 00:08:18]

megjablon@chromium.org changed reviewers:
+ bengr@chromium.org

[megjablon, 2015-02-27 00:08:18]

You mentioned something about looking at a larger image after checking the
number of bytes. I figured I'd just have you take a look at the test, and we can
work out what needs to be added.

[bengr, 2015-02-27 23:38:38]

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py (right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:128:
options.AppendExtraBrowserArgs('--enable-spdy-proxy-auth')
The lofi flag should be added in measurements. None of the benchmarks should
have flags, including the one other that already does. While you're here, remove
that one too.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:31: """Chrome
proxy data saving measurement."""
:)

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:290: class
ChromeProxyLoFi(ChromeProxyValidation):
Add a CustomizeBrowserOptions() with the lofi header. See other examples in this
file.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:215: 'Image %s is
%d bytes. Expecting less than 100 bytes' %
Add a period.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py
(right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:10: 
Add a comment.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:16: 
Remove blank line.

[megjablon, 2015-02-28 00:57:33]

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py (right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:128:
options.AppendExtraBrowserArgs('--enable-spdy-proxy-auth')
On 2015/02/27 23:38:38, bengr wrote:
> The lofi flag should be added in measurements. None of the benchmarks should
> have flags, including the one other that already does. While you're here,
remove
> that one too.

Done.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:31: """Chrome
proxy data saving measurement."""
On 2015/02/27 23:38:38, bengr wrote:
> :)

Acknowledged.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:290: class
ChromeProxyLoFi(ChromeProxyValidation):
On 2015/02/27 23:38:38, bengr wrote:
> Add a CustomizeBrowserOptions() with the lofi header. See other examples in
this
> file.

Done.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:215: 'Image %s is
%d bytes. Expecting less than 100 bytes' %
On 2015/02/27 23:38:38, bengr wrote:
> Add a period.

Done.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py
(right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:10: 
On 2015/02/27 23:38:38, bengr wrote:
> Add a comment.

Done.

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:16: 
On 2015/02/27 23:38:38, bengr wrote:
> Remove blank line.
We have this spacing in all these files. Should I fix all of them?

[bengr, 2015-03-03 18:20:31]

lgtm

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py
(right):

https://codereview.chromium.org/942863004/diff/40001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi.py:16: 
On 2015/02/28 00:57:33, megjablon wrote:
> On 2015/02/27 23:38:38, bengr wrote:
> > Remove blank line.
> We have this spacing in all these files. Should I fix all of them?

If you'd like to. Not required.

[megjablon, 2015-03-03 19:16:19]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2015-03-03 19:16:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/942863004/#ps80001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-03-03 19:16:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942863004/80001

[commit-bot: I haz the power, 2015-03-03 19:20:32]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-03-03 19:21:35]

Patchset 3 (id:??) landed as
https://crrev.com/d2e455390173cf46497d048f796a7d907e445c47
Cr-Commit-Position: refs/heads/master@{#318926}