Fix variation id transmission with feedback reports.

Fix variation id transmission with feedback reports.

This was originally added by this CL:
https://chromiumcodereview.appspot.com/15714003

But later broke when the code was componentized here:
https://codereview.chromium.org/116863002

This CL restores the original functionality and adds
a test to hopefully prevent it from regressing in the
future.

BUG=460604
Committed: https://crrev.com/e6f7a58b12228773ef182a5481d381c427505740
Cr-Commit-Position: refs/heads/master@{#317655}

[Alexei Svitkine (slow), 2015-02-20 22:25:20]

asvitkine@chromium.org changed reviewers:
+ rkc@chromium.org

[rkc, 2015-02-20 22:29:19]

lgtm

[Alexei Svitkine (slow), 2015-02-20 22:31:20]

asvitkine@chromium.org changed reviewers:
+ bsimonnet@chromium.org

[Alexei Svitkine (slow), 2015-02-20 22:31:21]

+bsimonnet for components/feedback owners as rkc@ isn't an owner apparently...

[bsimonnet, 2015-02-20 22:56:43]

On 2015/02/20 22:31:21, Alexei Svitkine wrote:
> +bsimonnet for components/feedback owners as rkc@ isn't an owner apparently...

lgtm

[Alexei Svitkine (slow), 2015-02-20 23:02:12]

Thanks.

Hmm, some android test failures - I'll have to take a look next week.

[Alexei Svitkine (slow), 2015-02-23 17:41:04]

New patchsets have been uploaded after l-g-t-m from
rkc@chromium.org,bsimonnet@chromium.org

[Alexei Svitkine (slow), 2015-02-23 17:46:51]

Patchset #3 (id:40001) has been deleted

[Alexei Svitkine (slow), 2015-02-23 19:21:52]

Patchset #3 (id:60001) has been deleted

[Alexei Svitkine (slow), 2015-02-23 19:21:59]

Patchset #3 (id:80001) has been deleted

[Alexei Svitkine (slow), 2015-02-23 19:23:04]

Patchset #3 (id:100001) has been deleted

[Alexei Svitkine (slow), 2015-02-23 19:24:26]

Patchset #3 (id:120001) has been deleted

[Alexei Svitkine (slow), 2015-02-23 19:25:01]

Updated to fix a leak in the test and exclude the new test on Android (which
doesn't build feedback). Changes are trivial, so cq'ing based on previous lgtms.

[Alexei Svitkine (slow), 2015-02-23 19:25:08]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2015-02-23 19:26:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942863003/140001

[commit-bot: I haz the power, 2015-02-23 19:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 19:30:52]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Alexei Svitkine (slow), 2015-02-23 19:33:44]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2015-02-23 19:34:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942863003/140001

[commit-bot: I haz the power, 2015-02-23 19:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 19:38:32]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Alexei Svitkine (slow), 2015-02-23 19:42:55]

+chrome-troopers

The "Find Xcode" step seems to be failing on the iOS bots. Any ideas?

On Mon, Feb 23, 2015 at 2:38 PM, <commit-bot@chromium.org> wrote:

> Try jobs failed on following builders:
>   ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
> http://build.chromium.org/p/tryserver.chromium.mac/
> builders/ios_dbg_simulator/builds/61865)
>
> https://codereview.chromium.org/942863003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-02-23 21:22:50]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942863003/140001

[commit-bot: I haz the power, 2015-02-23 21:25:06]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-02-23 21:25:53]

Patchset 3 (id:??) landed as
https://crrev.com/e6f7a58b12228773ef182a5481d381c427505740
Cr-Commit-Position: refs/heads/master@{#317655}