Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 942853002: Fix layer hoisting bug in SkCanvas::drawPicture path (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix layer hoisting bug in SkCanvas::drawPicture path Most of this CL is just reordering to better match the MultiPictureDraw variant. The only functional change is that we now use the device space bounds as the queryRect to the layer hoisting code. This is necessary since the layer hoisting does all its work in device space. Committed: https://skia.googlesource.com/skia/+/e5524cd52d56f9b70d9b4a83bd73a3fa75d56509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M src/gpu/SkGpuDevice.cpp View 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
5 years, 10 months ago (2015-02-20 16:12:57 UTC) #2
bsalomon
5 years, 10 months ago (2015-02-20 16:45:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942853002/1
5 years, 10 months ago (2015-02-20 16:45:59 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-20 16:45:59 UTC) #6
bsalomon
On 2015/02/20 16:45:18, bsalomon wrote: lgtm
5 years, 10 months ago (2015-02-20 16:46:13 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:30:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e5524cd52d56f9b70d9b4a83bd73a3fa75d56509

Powered by Google App Engine
This is Rietveld 408576698