Chromium Code Reviews

Issue 942833002: Only normalize prototypes in OptimizeAsPrototype if it would benefit. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only normalize prototypes in OptimizeAsPrototype if it would benefit. BUG= Committed: https://crrev.com/6e346dfc8435114a1c65e259060481c92e43a439 Cr-Commit-Position: refs/heads/master@{#26781}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+20 lines, -1 line)
M src/objects.cc View 1 chunk +20 lines, -1 line 0 comments

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-20 14:03:48 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-20 14:09:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942833002/1
5 years, 10 months ago (2015-02-20 14:14:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:29:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:29:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 15:30:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e346dfc8435114a1c65e259060481c92e43a439
Cr-Commit-Position: refs/heads/master@{#26781}

Powered by Google App Engine