Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 942813002: Oilpan: prefer ENABLE(OILPAN). (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, oilpan-reviews, Mads Ager (chromium), Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rwlbuis, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, kouhei+heap_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: prefer ENABLE(OILPAN). R=kouhei Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190565

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M Source/core/animation/InterpolableValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/InterpolationEffect.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +1 line, -3 lines 1 comment Download
M Source/platform/heap/HeapTest.cpp View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look. https://codereview.chromium.org/942813002/diff/1/Source/core/css/CSSImageGeneratorValue.cpp File Source/core/css/CSSImageGeneratorValue.cpp (left): https://codereview.chromium.org/942813002/diff/1/Source/core/css/CSSImageGeneratorValue.cpp#oldcode104 Source/core/css/CSSImageGeneratorValue.cpp:104: #if !ENABLE_OILPAN The #if here ...
5 years, 10 months ago (2015-02-20 12:20:49 UTC) #2
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-20 12:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942813002/1
5 years, 10 months ago (2015-02-20 12:27:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190565
5 years, 10 months ago (2015-02-20 14:07:40 UTC) #7
haraken
5 years, 10 months ago (2015-02-20 20:20:00 UTC) #8
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698