Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 942803002: [tracing] Fix MemoryDumpManager testing instance teardown pattern. (Closed)

Created:
5 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Fix MemoryDumpManager testing instance teardown pattern. crrev.com/933613002 introduced a ODR violtaion by adding the DeleteForTesting method (other definition in trace_event_impl.cc). This was causing an ASan assertion (see crbug.com/459556) and failures of base_unittests in debug builds (see crrev.com/933613002 #33). This CL fixes the DeleteForTesting pattern removing the awkward ODR violation. BUG=459556, 458295 TBR=nduca@chromium.org Committed: https://crrev.com/97206c26057c11573bf6aea8aff40ee345874648 Cr-Commit-Position: refs/heads/master@{#317316}

Patch Set 1 #

Patch Set 2 : Simplify memory ownership #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M base/trace_event/memory_dump_manager.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 2 chunks +9 lines, -14 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sami
Thanks, lgtm.
5 years, 10 months ago (2015-02-20 12:16:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942803002/20001
5 years, 10 months ago (2015-02-20 12:17:41 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 14:31:23 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:32:06 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97206c26057c11573bf6aea8aff40ee345874648
Cr-Commit-Position: refs/heads/master@{#317316}

Powered by Google App Engine
This is Rietveld 408576698