Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 942793002: [iOS] Upstream chrome commands (Closed)

Created:
5 years, 10 months ago by droger
Modified:
5 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream chrome commands BUG=452493 Committed: https://crrev.com/25bd73e5ca8c842565f55d3a0def5036a79a7b15 Cr-Commit-Position: refs/heads/master@{#317558}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -0 lines) Patch
A ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.mm View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/generic_chrome_command.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/generic_chrome_command.mm View 1 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/open_url_command.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/open_url_command.mm View 1 1 chunk +76 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/url_loader.h View 1 1 chunk +62 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
droger
5 years, 10 months ago (2015-02-20 10:30:32 UTC) #2
droger
Please Check the CQ button if this looks good. Thanks.
5 years, 10 months ago (2015-02-20 23:38:32 UTC) #4
sdefresne
lgtm
5 years, 10 months ago (2015-02-23 10:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942793002/40001
5 years, 10 months ago (2015-02-23 10:18:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-23 10:25:58 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 10:26:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25bd73e5ca8c842565f55d3a0def5036a79a7b15
Cr-Commit-Position: refs/heads/master@{#317558}

Powered by Google App Engine
This is Rietveld 408576698