Issue 942783002: Simplifying Firefox download script, fixing bugs, disabling on win/mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 942783002: Simplifying Firefox download script, fixing bugs, disabling on win/mac. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium

Modified:
5 years, 10 months ago

Reviewers:
kjellander_chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/webrtc/webrtc.DEPS/

Visibility:
Public.

Simplifying Firefox download script, fixing bugs, disabling on win/mac. It's unlikely I'll implement the FF test on win or mac anytime soon, so I may as well clean up that code. Also the script has broken on Win because of a Firefox-side change: disabling the script on win/mac for now. TBR=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/294138

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -24 lines)			Patch
	M	download_firefox_nightly.py	View		5 chunks	+9 lines, -24 lines	0 comments	Download

Total messages: 4 (1 generated)

phoglund_chromium

Committed patchset #1 (id:1) manually as r294138 (presubmit successful).

5 years, 10 months ago (2015-02-20 09:01:06 UTC) #3

Message was sent while issue was closed.

lgtm