Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 942743003: Extend the new "Manage Passwords" bubble with the buttons. (Closed)

Created:
5 years, 10 months ago by vasilii
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend the new "Manage Passwords" bubble with the buttons. Also fix the alignment in the "Blacklisted" bubble. BUG=400674 Committed: https://crrev.com/c99988c3d4bcf4ddceb16edaac1f24c85d6503b9 Cr-Commit-Position: refs/heads/master@{#318027}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -25 lines) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 6 chunks +83 lines, -24 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
vasilii
Hi Mike, please review.
5 years, 10 months ago (2015-02-25 11:05:17 UTC) #2
Mike West
LGTM. https://codereview.chromium.org/942743003/diff/1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right): https://codereview.chromium.org/942743003/diff/1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc#newcode744 chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:744: l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_NO_PASSWORDS), Will you be folding blacklisting in here ...
5 years, 10 months ago (2015-02-25 11:40:26 UTC) #3
vasilii
Thank you! https://codereview.chromium.org/942743003/diff/1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right): https://codereview.chromium.org/942743003/diff/1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc#newcode744 chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:744: l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_NO_PASSWORDS), On 2015/02/25 11:40:26, Mike West wrote: ...
5 years, 10 months ago (2015-02-25 11:46:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942743003/1
5 years, 10 months ago (2015-02-25 11:47:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 11:57:59 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 11:58:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c99988c3d4bcf4ddceb16edaac1f24c85d6503b9
Cr-Commit-Position: refs/heads/master@{#318027}

Powered by Google App Engine
This is Rietveld 408576698