Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 942683003: Chromecast: adds CastCryptoMsgStart to IPCMessageStart list. (Closed)

Created:
5 years, 10 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam, lcwu1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds CastCryptoMsgStart to IPCMessageStart list. R=tsepez@chromium.org BUG=336640 Committed: https://crrev.com/d1f98807766c93a37d1413990b07f647011097aa Cr-Commit-Position: refs/heads/master@{#317710}

Patch Set 1 #

Patch Set 2 : adds notice above CastCryptoMsgStart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ipc/ipc_message_start.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
Hey, quick context since this is on its own without a message header file: Chromecast ...
5 years, 10 months ago (2015-02-23 21:56:40 UTC) #1
Tom Sepez
Ok, this hasn't come up before, but I'm OK with it so long as you ...
5 years, 10 months ago (2015-02-23 22:00:04 UTC) #2
gunsch
On 2015/02/23 22:00:04, Tom Sepez wrote: > Ok, this hasn't come up before, but I'm ...
5 years, 10 months ago (2015-02-23 22:03:15 UTC) #3
Tom Sepez
lgtm
5 years, 10 months ago (2015-02-23 22:04:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942683003/20001
5 years, 10 months ago (2015-02-23 22:06:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 01:05:46 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:06:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1f98807766c93a37d1413990b07f647011097aa
Cr-Commit-Position: refs/heads/master@{#317710}

Powered by Google App Engine
This is Rietveld 408576698