Plugin Power Saver: Add Poster Param metric.

Plugin Power Saver: Add Poster Param metric.

BUG=460272, 403800
Committed: https://crrev.com/30c7708765dcc486c96df13bacafa28a823ba645
Cr-Commit-Position: refs/heads/master@{#317392}

[tommycli, 2015-02-20 00:20:42]

tommycli@chromium.org changed reviewers:
+ groby@chromium.org

[tommycli, 2015-02-20 00:20:42]

groby: Is this what you had in mind for a poster param metric?

[groby-ooo-7-16, 2015-02-20 02:10:22]

groby@chromium.org changed reviewers:
+ asvitkine@chromium.org

[groby-ooo-7-16, 2015-02-20 02:10:23]

This LGTM to me - but check with somebody who's more familiar with metrics if
this is the sane thing to do. asvitkine?

[Alexei Svitkine (slow), 2015-02-20 13:54:52]

lgtm % comments

https://codereview.chromium.org/942673002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/942673002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:26745: +  <summary>Record how many
plugin object tags use poster param.</summary>
Nit: Mention when this is recorded. e.g. on every page load? Or, once per plugin
object seen? Or ...?

Also, mention that this is specific to Flash plugins, since that's what the code
appears to be doing.

[tommycli, 2015-02-20 17:18:59]

New patchsets have been uploaded after l-g-t-m from
groby@chromium.org,asvitkine@chromium.org

[tommycli, 2015-02-20 17:20:01]

groby/alexi:

thanks!

https://codereview.chromium.org/942673002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/942673002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:26745: +  <summary>Record how many
plugin object tags use poster param.</summary>
On 2015/02/20 13:54:51, Alexei Svitkine wrote:
> Nit: Mention when this is recorded. e.g. on every page load? Or, once per
plugin
> object seen? Or ...?
> 
> Also, mention that this is specific to Flash plugins, since that's what the
code
> appears to be doing.

Done.

[tommycli, 2015-02-20 17:21:16]

jhawkins: May I have a review for chrome_content_renderer_client.cc?

Tommy

[tommycli, 2015-02-20 17:21:41]

tommycli@chromium.org changed reviewers:
+ jhawkins@chromium.org

[tommycli, 2015-02-20 17:21:41]

jhawkins: May I have a review for chrome_content_renderer_client.cc?

Thanks!

[James Hawkins, 2015-02-20 17:33:31]

I'm OOO till Monday.
On Feb 20, 2015 9:21 AM, <tommycli@chromium.org> wrote:

> jhawkins: May I have a review for chrome_content_renderer_client.cc?
>
> Thanks!
>
> https://codereview.chromium.org/942673002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tommycli, 2015-02-20 17:41:18]

tommycli@chromium.org changed reviewers:
+ sky@chromium.org
- jhawkins@chromium.org

[tommycli, 2015-02-20 17:41:44]

sky: May I have a review for chrome_content_renderer_client.cc?

[sky, 2015-02-20 18:12:26]

LGTM

https://codereview.chromium.org/942673002/diff/20001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/942673002/diff/20001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client.cc:285: void
RecordPosterParamPresence(int presence) {
int->PosterParamPresence ?

[tommycli, 2015-02-20 18:16:27]

New patchsets have been uploaded after l-g-t-m from sky@chromium.org

[tommycli, 2015-02-20 18:17:03]

sky: Thanks!

https://codereview.chromium.org/942673002/diff/20001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/942673002/diff/20001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client.cc:285: void
RecordPosterParamPresence(int presence) {
On 2015/02/20 18:12:26, sky wrote:
> int->PosterParamPresence ?

Done.

[tommycli, 2015-02-20 18:17:09]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-02-20 18:19:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942673002/40001

[commit-bot: I haz the power, 2015-02-20 20:41:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-20 20:42:33]

Patchset 3 (id:??) landed as
https://crrev.com/30c7708765dcc486c96df13bacafa28a823ba645
Cr-Commit-Position: refs/heads/master@{#317392}