Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/telemetry/telemetry/util/find_dependencies.py

Issue 942663002: [Telemetry] Pass test_runner environment in local args instead of a global variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix find_dependencies issue Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/unittest_util/run_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/util/find_dependencies.py
diff --git a/tools/telemetry/telemetry/util/find_dependencies.py b/tools/telemetry/telemetry/util/find_dependencies.py
index bdabc70d093136eaac12b83c682f878a56ae8e51..6b37b4e91bf973e6a9b01375a69d25734626534d 100644
--- a/tools/telemetry/telemetry/util/find_dependencies.py
+++ b/tools/telemetry/telemetry/util/find_dependencies.py
@@ -77,7 +77,7 @@ def FindPageSetDependencies(base_dir):
# Ensure the test's default options are set if needed.
parser = optparse.OptionParser()
- test_obj.AddCommandLineArgs(parser)
+ test_obj.AddCommandLineArgs(parser, None)
options = optparse.Values()
for k, v in parser.get_default_values().__dict__.iteritems():
options.ensure_value(k, v)
@@ -227,7 +227,7 @@ class FindDependenciesCommand(command_line.OptparseCommand):
"""Prints all dependencies"""
@classmethod
- def AddCommandLineArgs(cls, parser):
+ def AddCommandLineArgs(cls, parser, _):
parser.add_option(
'-v', '--verbose', action='count', dest='verbosity',
help='Increase verbosity level (repeat as needed).')
@@ -245,7 +245,7 @@ class FindDependenciesCommand(command_line.OptparseCommand):
help='Store files in a zip archive at ZIP.')
@classmethod
- def ProcessCommandLineArgs(cls, parser, args):
+ def ProcessCommandLineArgs(cls, parser, args, _):
if args.verbosity >= 2:
logging.getLogger().setLevel(logging.DEBUG)
elif args.verbosity:
« no previous file with comments | « tools/telemetry/telemetry/unittest_util/run_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698