Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: tools/telemetry/telemetry/core/command_line.py

Issue 942663002: [Telemetry] Pass test_runner environment in local args instead of a global variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix find_dependencies issue Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/benchmark_runner.py ('k') | tools/telemetry/telemetry/core/environment.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/command_line.py
diff --git a/tools/telemetry/telemetry/core/command_line.py b/tools/telemetry/telemetry/core/command_line.py
index 450cd0d8076f3403debab527f19a20734735dd84..e26bc7c06ddfc910039d70ba34a2def9919daf75 100644
--- a/tools/telemetry/telemetry/core/command_line.py
+++ b/tools/telemetry/telemetry/core/command_line.py
@@ -64,6 +64,16 @@ class OptparseCommand(Command):
return optparse.OptionParser('%%prog %s %s' % (cls.Name(), cls.usage),
description=cls.Description())
+ @classmethod
+ def AddCommandLineArgs(cls, parser, environment):
+ # pylint: disable=arguments-differ
+ pass
+
+ @classmethod
+ def ProcessCommandLineArgs(cls, parser, args, environment):
+ # pylint: disable=arguments-differ
+ pass
+
def Run(self, args):
raise NotImplementedError()
@@ -71,10 +81,10 @@ class OptparseCommand(Command):
def main(cls, args=None):
"""Main method to run this command as a standalone script."""
parser = cls.CreateParser()
- cls.AddCommandLineArgs(parser)
+ cls.AddCommandLineArgs(parser, None)
options, args = parser.parse_args(args=args)
options.positional_args = args
- cls.ProcessCommandLineArgs(parser, options)
+ cls.ProcessCommandLineArgs(parser, options, None)
return min(cls().Run(options), 255)
« no previous file with comments | « tools/telemetry/telemetry/benchmark_runner.py ('k') | tools/telemetry/telemetry/core/environment.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698