Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: storage/browser/fileapi/local_file_stream_writer.cc

Issue 942633004: IndexedDB: Fixed support for empty blobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Deleted CREATE_NEW_FILE. Creating file before using FileStreamWriter. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/fileapi/local_file_stream_writer.cc
diff --git a/storage/browser/fileapi/local_file_stream_writer.cc b/storage/browser/fileapi/local_file_stream_writer.cc
index c6a1d5122fcc6445d93a850e24f8ae34e4487e4e..48f24768c0591ab0fcf70fb05905f1a0bc15a47f 100644
--- a/storage/browser/fileapi/local_file_stream_writer.cc
+++ b/storage/browser/fileapi/local_file_stream_writer.cc
@@ -18,19 +18,14 @@ namespace {
const int kOpenFlagsForWrite = base::File::FLAG_OPEN |
base::File::FLAG_WRITE |
base::File::FLAG_ASYNC;
-const int kCreateFlagsForWrite = base::File::FLAG_CREATE |
- base::File::FLAG_WRITE |
- base::File::FLAG_ASYNC;
} // namespace
FileStreamWriter* FileStreamWriter::CreateForLocalFile(
base::TaskRunner* task_runner,
const base::FilePath& file_path,
- int64 initial_offset,
- OpenOrCreate open_or_create) {
- return new LocalFileStreamWriter(
- task_runner, file_path, initial_offset, open_or_create);
+ int64 initial_offset) {
+ return new LocalFileStreamWriter(task_runner, file_path, initial_offset);
}
LocalFileStreamWriter::~LocalFileStreamWriter() {
@@ -87,14 +82,13 @@ int LocalFileStreamWriter::Flush(const net::CompletionCallback& callback) {
LocalFileStreamWriter::LocalFileStreamWriter(base::TaskRunner* task_runner,
const base::FilePath& file_path,
- int64 initial_offset,
- OpenOrCreate open_or_create)
+ int64 initial_offset)
: file_path_(file_path),
- open_or_create_(open_or_create),
initial_offset_(initial_offset),
task_runner_(task_runner),
has_pending_operation_(false),
- weak_factory_(this) {}
+ weak_factory_(this) {
+}
int LocalFileStreamWriter::InitiateOpen(
const net::CompletionCallback& error_callback,
@@ -104,22 +98,10 @@ int LocalFileStreamWriter::InitiateOpen(
stream_impl_.reset(new net::FileStream(task_runner_));
- int open_flags = 0;
- switch (open_or_create_) {
- case OPEN_EXISTING_FILE:
- open_flags = kOpenFlagsForWrite;
- break;
- case CREATE_NEW_FILE:
- open_flags = kCreateFlagsForWrite;
- break;
- }
-
- return stream_impl_->Open(file_path_,
- open_flags,
- base::Bind(&LocalFileStreamWriter::DidOpen,
- weak_factory_.GetWeakPtr(),
- error_callback,
- main_operation));
+ return stream_impl_->Open(
+ file_path_, kOpenFlagsForWrite,
+ base::Bind(&LocalFileStreamWriter::DidOpen, weak_factory_.GetWeakPtr(),
+ error_callback, main_operation));
}
void LocalFileStreamWriter::DidOpen(

Powered by Google App Engine
This is Rietveld 408576698