IndexedDB: Fixed support for empty blobs.

storage/browser/blob/blob_data_builder.cc

Index: storage/browser/blob/blob_data_builder.cc
diff --git a/storage/browser/blob/blob_data_builder.cc b/storage/browser/blob/blob_data_builder.cc
index 51946c882f4e8dfec78e38fdfe4966c771695d7e..e7049d6210bc970a82920b0a0100a2557964188a 100644
--- a/storage/browser/blob/blob_data_builder.cc
+++ b/storage/browser/blob/blob_data_builder.cc
@@ -15,7 +15,6 @@ BlobDataBuilder::~BlobDataBuilder() {
 }
 
 void BlobDataBuilder::AppendData(const char* data, size_t length) {
-  DCHECK(length > 0);

[michaeln, 2015/03/06 22:31:38]

i'd probably go for an early return here to avoid special cases and untested
code paths downstream

[cmumford, 2015/03/09 20:05:48]

It's actually back in now. Was only removed for the test, which as you pointed
out was incorrect.

   scoped_ptr<DataElement> element(new DataElement());
   element->SetToBytes(data, length);
   items_.push_back(new BlobDataItem(element.Pass()));
@@ -25,7 +24,6 @@ void BlobDataBuilder::AppendFile(const base::FilePath& file_path,
                                  uint64_t offset,
                                  uint64_t length,
                                  const base::Time& expected_modification_time) {
-  DCHECK(length > 0);
   scoped_ptr<DataElement> element(new DataElement());
   element->SetToFilePathRange(file_path, offset, length,
                               expected_modification_time);