storage/browser/blob/blob_data_builder.cc - Issue 942633004: IndexedDB: Fixed support for empty blobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_data_builder.cc

Issue 942633004: IndexedDB: Fixed support for empty blobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Backing store now creating empty file + test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/blob/blob_data_builder.cc

diff --git a/storage/browser/blob/blob_data_builder.cc b/storage/browser/blob/blob_data_builder.cc

index 51946c882f4e8dfec78e38fdfe4966c771695d7e..ad965b1180a020b598c77fe1c32653ea8d48b133 100644

--- a/storage/browser/blob/blob_data_builder.cc

+++ b/storage/browser/blob/blob_data_builder.cc

@@ -25,7 +25,9 @@ void BlobDataBuilder::AppendFile(const base::FilePath& file_path,

uint64_t offset,

uint64_t length,

const base::Time& expected_modification_time) {

- DCHECK(length > 0);

+ if (!length)

+ return;

scoped_ptr<DataElement> element(new DataElement());

element->SetToFilePathRange(file_path, offset, length,

expected_modification_time);