IndexedDB: Fixed support for empty blobs.

net/base/file_stream_context_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/file_stream_context.h"
 
 #include <errno.h>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 85 matching lines @@
   int res = file_.ReadAtCurrentPosNoBestEffort(buf->data(), buf_len);
   if (res == -1)
     return IOResult::FromOSError(errno);
 
   return IOResult(res, 0);
 }
 
 FileStream::Context::IOResult FileStream::Context::WriteFileImpl(
     scoped_refptr<IOBuffer> buf,
     int buf_len) {
+  if (buf_len == 0)

[jsbell, 2015/02/24 18:37:36]

Can you explain why we need this special case? Does
WriteAtCurrentPosNoBestEffort error out if the length is zero? If so, do we want
to change the semantics of this API, or short-circuit closer to the Blob code?

(This seems entirely reasonable, I'm just nervous...)

[cmumford, 2015/02/24 22:40:52]

buf refers to a NULL IOBuffer in this case. So operator-> is what's failing
without this check. I'd rather stay out of net/base, and will see if I can do
that. However, going two levels up the callstack FileStream::Write allows for
writing zero bytes (see DCHECK_GE), so maybe the solution should be in net/base.
What do you think?

[jsbell, 2015/02/25 00:10:30]

Although you took a different approach, it is weird if FileStream::Write is
effectively calling WriteFileImpl(nullptr, 0) !

+    return IOResult(0, 0);
   int res = file_.WriteAtCurrentPosNoBestEffort(buf->data(), buf_len);
   if (res == -1)
     return IOResult::FromOSError(errno);
 
   return IOResult(res, 0);
 }
 
 }  // namespace net