Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 942543002: Add back Element#getBoundingClient rect (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
hansmuller, hansmuller1
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add back Element#getBoundingClient rect Hans is using this in Modular and we don't have a great replacement at the moment. R=hansmuller@google.com, hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d8c271ee4a2ebf616d4ce1d39dab69faea263bbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sky/engine/core/dom/Element.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-19 17:53:26 UTC) #1
hansmuller1
LGTM
5 years, 10 months ago (2015-02-19 17:56:55 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-02-19 18:02:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8c271ee4a2ebf616d4ce1d39dab69faea263bbf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698