Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: extensions/browser/script_executor.h

Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_routingid_user_script_UserScriptSet_non_hostset_2
Patch Set: nits. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/script_executor.h
diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h
index c4ecb008d06efec79f9c802e14dc4afafbd85991..5e3cd75b4c7566738a73b94b58fd6cd465f06bae 100644
--- a/extensions/browser/script_executor.h
+++ b/extensions/browser/script_executor.h
@@ -85,7 +85,8 @@ class ScriptExecutor {
// |callback| will always be called even if the IPC'd renderer is destroyed
// before a response is received (in this case the callback will be with a
// failure and appropriate error message).
- void ExecuteScript(const std::string& extension_id,
+ void ExecuteScript(const HostID::HostType& host_type,
Devlin 2015/02/25 17:22:36 two things: - passing an enum by const & is silly.
Xi Han 2015/02/26 15:13:45 Good point, updated.
+ const std::string& host_id,
ScriptType script_type,
const std::string& code,
FrameScope frame_scope,

Powered by Google App Engine
This is Rietveld 408576698