Enable <webview>.executeScript outside of Apps and Extensions [1]

extensions/renderer/programmatic_script_injector.cc

Index: extensions/renderer/programmatic_script_injector.cc
diff --git a/extensions/renderer/programmatic_script_injector.cc b/extensions/renderer/programmatic_script_injector.cc
index f393f9e213a299cf1244d467752264942bd426a6..c0656b541c4540c3b550552efd372a98f48466f4 100644
--- a/extensions/renderer/programmatic_script_injector.cc
+++ b/extensions/renderer/programmatic_script_injector.cc
@@ -83,6 +83,9 @@ PermissionsData::AccessType ProgrammaticScriptInjector::CanExecuteOnFrame(
                : PermissionsData::ACCESS_DENIED;
   }
 
+  if (injection_host->id().type() != HostID::EXTENSIONS)
+    return PermissionsData::ACCESS_DENIED;

[Fady Samuel, 2015/02/19 19:52:54]

I'm confused by this, doesn't this disable executeScript for WebUI?

[Xi Han, 2015/02/19 19:56:04]

Yes, this disable executeScript for WebUI, but not <webview>.executeCode on
WebUI, which has been handled in line 75. Right?

+
   return injection_host->CanExecuteOnFrame(
       effective_document_url, top_url, tab_id, true /* is_declarative */);
 }