extensions/browser/script_executor.h - Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/script_executor.h

Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_routingid_user_script_UserScriptSet_non_hostset_2

Patch Set: nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/script_executor.h

diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h

index c4ecb008d06efec79f9c802e14dc4afafbd85991..322e9bbb881ca05a377dee9bfae38a3bc0b6fd58 100644

--- a/extensions/browser/script_executor.h

+++ b/extensions/browser/script_executor.h

@@ -85,7 +85,7 @@ class ScriptExecutor {

// |callback| will always be called even if the IPC'd renderer is destroyed

// before a response is received (in this case the callback will be with a

// failure and appropriate error message).

- void ExecuteScript(const std::string& extension_id,

+ void ExecuteScript(const HostID& host_id,

ScriptType script_type,

const std::string& code,

FrameScope frame_scope,

« no previous file with comments | « extensions/browser/api/web_view/web_view_internal_api.cc ('k') | extensions/browser/script_executor.cc » ('j') | no next file with comments »