extensions/renderer/programmatic_script_injector.cc - Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/programmatic_script_injector.cc

Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_routingid_user_script_UserScriptSet_non_hostset_2

Patch Set: Add a test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extension_messages.h ('K') | « extensions/renderer/extension_injection_host.cc ('k') | extensions/renderer/script_injection_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/programmatic_script_injector.cc

diff --git a/extensions/renderer/programmatic_script_injector.cc b/extensions/renderer/programmatic_script_injector.cc

index 19259dff2c67a5f78ab3ad652c327a09f76eb569..e4f82bb5251203dd9af09604c1e4cdd55ddc8729 100644

--- a/extensions/renderer/programmatic_script_injector.cc

+++ b/extensions/renderer/programmatic_script_injector.cc

@@ -82,6 +82,7 @@ PermissionsData::AccessType ProgrammaticScriptInjector::CanExecuteOnFrame(

? PermissionsData::ACCESS_ALLOWED

: PermissionsData::ACCESS_DENIED;

}

+ DCHECK(injection_host->id().type() == HostID::EXTENSIONS);

Devlin 2015/03/09 16:04:42 use DCHECK_EQ

Xi Han 2015/03/09 17:59:56 Done.

return injection_host->CanExecuteOnFrame(

effective_document_url, top_url, tab_id, true /* is_declarative */);

« extensions/common/extension_messages.h ('K') | « extensions/renderer/extension_injection_host.cc ('k') | extensions/renderer/script_injection_manager.cc » ('j') | no next file with comments »