extensions/browser/api/web_view/web_view_internal_api.cc - Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_view/web_view_internal_api.cc

Issue 942533003: Enable <webview>.executeScript outside of Apps and Extensions [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_routingid_user_script_UserScriptSet_non_hostset_2

Patch Set: Add a test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/webview_execute_script_test.js ('K') | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/script_executor.h » ('j') | extensions/common/extension_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_view/web_view_internal_api.cc

diff --git a/extensions/browser/api/web_view/web_view_internal_api.cc b/extensions/browser/api/web_view/web_view_internal_api.cc

index 4b041e911764efabd574034f0e175b015ffebd65..dd9842ad6985207df51b2cf12e617be0fce85875 100644

--- a/extensions/browser/api/web_view/web_view_internal_api.cc

+++ b/extensions/browser/api/web_view/web_view_internal_api.cc

@@ -102,7 +102,19 @@ bool WebViewInternalExecuteCodeFunction::Init() {

return false;

details_ = details.Pass();

- return true;

+ if (extension()) {

+ set_host_id(HostID(HostID::EXTENSIONS, extension()->id()));

+ return true;

+ }

+ WebContents* web_contents = GetSenderWebContents();

+ if (web_contents && web_contents->GetWebUI()) {

+ const GURL& url = render_view_host()->GetSiteInstance()->GetSiteURL();

+ set_host_id(HostID(HostID::WEBUI, url.spec()));

+ return true;

+ }

+ return false;

}

bool WebViewInternalExecuteCodeFunction::ShouldInsertCSS() const {