Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 942523003: Drop Intrusive*TransitionIterators, use recursion instead. (Closed)

Created:
5 years, 10 months ago by Jakob Kummerow
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop Intrusive*TransitionIterators, use recursion instead. We already use recursion to iterate over transition trees elsewhere, so this should be safe wrt. call stack height. Committed: https://crrev.com/32bac2df4919fa3e82761fbd6035cbb4109af6ba Cr-Commit-Position: refs/heads/master@{#26813}

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -189 lines) Patch
M src/objects.cc View 1 2 1 chunk +20 lines, -189 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL. I have more when you're done with this :-)
5 years, 9 months ago (2015-02-24 09:56:20 UTC) #2
Toon Verwaest
lgtm
5 years, 9 months ago (2015-02-24 10:22:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942523003/40001
5 years, 9 months ago (2015-02-24 10:26:28 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-02-24 10:50:29 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-24 10:50:41 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/32bac2df4919fa3e82761fbd6035cbb4109af6ba
Cr-Commit-Position: refs/heads/master@{#26813}

Powered by Google App Engine
This is Rietveld 408576698